[Mapguide_dev] MapGuide Open Source 1.1.0 RC2

[Trevor Wekel]

Hi Tom,
 
The check went into trunk as part of a much larger submission.  After
some testing, I have noticed that this code does not correctly detect
the difference between a garbled stream and a stream of the wrong
version.  They are all detected as wrong version so I will need to add
some additional logic to discriminate between the two cases.  Here are
the relevant lines of code from the original submission:
 
 
>From StreamParser::ParseStreamHeader
 
Index: StreamParser.cpp
===================================================================
--- StreamParser.cpp    (revision 737)
+++ StreamParser.cpp    (revision 1028)
@@ -77,6 +77,12 @@
                 ret = true;
             }
         }
+
+        if (ret == false || MgStreamParser::StreamVersion !=
pStreamData->GetVersion())
+        {
+            throw new
MgStreamIoException(L"MgStreamParser.ParseStreamHeader", __LINE__,
__WFILE__, NULL, L"MgInvalidTC
PProtocol", NULL);
+        }
+
     }
 
     return ret;
 
 
>From MgCommand::GetResponse
 
Index: Command.cpp
===================================================================
--- Command.cpp (revision 770)
+++ Command.cpp (revision 1028)
@@ -141,6 +141,12 @@
 
     // Get the stream header i.e. stream_start, stream_data etc.
     ptrStream->GetStreamHeader(msh);
+
+    if (MgStreamParser::mshStreamStart != msh.m_streamStart ||
MgStreamParser::StreamVersion != msh.m_streamVersion)
+    {
+        throw new MgStreamIoException(L"MgCommand.GetResponse",
__LINE__, __WFILE__, NULL, L"MgInvalidTCPProtocol", NUL
L);
+    }
+
     // Get the operation response header
     ptrStream->GetOperationResponseHeader(morp);
     // Process the result based on eCode. In case of exception, it
would throw the exception


  _____  

From: Tom Fukushima 
Sent: Monday, January 08, 2007 10:00 AM
To: Trevor Wekel; 'mapguide_dev at lists.osgeo.org'
Subject: RE: [Mapguide_dev] MapGuide Open Source 1.1.0 RC2


Hi Trevor,
 
I would like to get an idea of the risk and size of the change.  Can you
give me the revision numbers for the submissions for this to the trunk?
 
Thanks
Tom

  _____  

From: Trevor Wekel 
Sent: Monday, January 08, 2007 9:42 AM
To: Tom Fukushima; mapguide_dev at lists.osgeo.org
Subject: RE: [Mapguide_dev] MapGuide Open Source 1.1.0 RC2


Hi Tom,
 
I would like to put a TCP/IP stream version check in the 1.1.0 release
to help catch versioning issues between the Web Extensions and Server
code bases.  Over time, improvements in the TCP/IP protocol will be
made.  Some of these improvements could break compatibility with older
releases.
 
Thanks,
Trevor
 

  _____  

From: mapguide_dev-bounces at lists.osgeo.org
[mailto:mapguide_dev-bounces at lists.osgeo.org] On Behalf Of Tom Fukushima
Sent: Sunday, January 07, 2007 9:26 PM
To: mapguide_dev at lists.osgeo.org
Subject: [Mapguide_dev] MapGuide Open Source 1.1.0 RC2



Hi, 

I would like to release MapGuide Open Source 1.1.0 RC2 in a couple of
weeks. This means that approved defect submissions to the 1.1.0 stream
need to be made by next weekend.  If you have a defect fix that you
would like to submit, please send it to this list for review.  If it is
a security related defect fix, please send it to me directly for review.

Thanks 
Tom 


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.osgeo.org/pipermail/mapguide_dev/attachments/20070108/edf357a1/attachment.html