[MapProxy-dev] RFC: Introduce linting

[Oliver Tonnhofer]

I'm 0 on this.

The benefits are there, but the IMO huge downside is that it "destroys" the history of the code (git blame, etc.).
It would see this different if there is ongoing active development, but most parts are quite stable, were not changed in recent years and will likely not be edited in the near future. 

All the best,
Oliver

> On 13. Jan 2021, at 08:36, Julien R <julien.rebetez at picterra.ch> wrote:
> 
> Hello,
> 
> I would like to propose adding linting to the mapproxy codebase and enforce it on the CI. The benefits of linting are mostly that they make reviews easier because reviewers don't have to point stylistic issues.
> 
> Johannes Weskamm originally proposed to introduce linting in this github issue:
> https://github.com/mapproxy/mapproxy/issues/478 <https://github.com/mapproxy/mapproxy/issues/478>
> 
> I personally have experience with using flake8 professionally for multiple years and it works great. I started experimenting with setting up flake8 on the CI here:
> https://github.com/mapproxy/mapproxy/pull/486 <https://github.com/mapproxy/mapproxy/pull/486>
> 
> If this is accepted, the plan would be to:
> - Introduce flake8 on CI, but disable all errors at first
> - Enable errors one by one in separate commits
> 
> This is to avoid submitting a massive PR touching everything. See the attached 'mapproxy_flake8_stats.txt' file for statistics about the "errors" found by flake8.
> 
> Best regards,
> Julien
> 
> --
> Julien Rebetez
> Lead Software & Machine Learning Engineer
> Picterra SA
> Rue de la Mouline 8, 1022 Chavannes, Switzerland
> www.picterra.ch <https://picterra.ch/?utm_source=signature&utm_medium=email&utm_campaign=43989-en-pt-email%20signature&utm_content=link><mapproxy_flake8_stats.txt>_______________________________________________
> MapProxy-dev mailing list
> MapProxy-dev at lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/mapproxy-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/mapproxy-dev/attachments/20210115/6c41f046/attachment.html>