[Mapserver-dev] cpl utility functions

[Daniel Morissette]

Daniel Morissette wrote:
> Yewondwossen Assefa wrote:
> 
>>>
>>> My take is similar to Daniel's.  I think that for small utility 
>>> functions
>>> from CPL, you should just replicate them into mapserver.  I would
>>> like to suggest though that:
>>>  o We make a map_cpl.c file with morphed code.
>>>  o We exactly change CPL to "ms" but otherwise leave the function the
>>>    same externally so it will be easy to use and recognise for folks who
>>>    know CPL a bit. So CPLGetBasename() would become msGetBasename().
>>>  o When you copy over the implementation you will of course need to
>>>    modify the code internally to use mapserver services for memory
>>>    allocation and various macros.  Most are pretty simple.
>>>
>>
>>  If there is no objection, I will add the functions I need into a new 
>> file map_cpl.c.
>>
> 
> I like Frank's suggestions as well... but perhaps call the file mapcpl.c 
> since there are no filenames with underscores (i.e. map_something.c) in 
> the MapServer source.
> 

Oh, and perhaps add a note in the header of the file to explain that 
this file is for code borrowed from the GDAL/OGR CPL library. Maybe also 
with a copy of the guidelines that Frank wrote above.

Daniel
-- 
------------------------------------------------------------
  Daniel Morissette               dmorissette at dmsolutions.ca
  DM Solutions Group              http://www.dmsolutions.ca/
------------------------------------------------------------