Flagging unused function arguments

Petter Reinholdtsen pere at HUNGRY.COM
Tue Jan 25 17:22:10 EST 2005


[Frank Warmerdam]
> I am not adverse to adding the above style definition and using it as
> you have suggested.

Sounds good.

> I would suggest adding it in map.h near the MS_DLL_EXPORT definition.
> I realize there are include files that don't include map.h (such as
> cgiutil.h and mapprimitive.h) but I would suggest we just modify
> them to include map.h.  This would also help get rid of multiple
> definitions of MS_DLL_EXPORT as we have now (in map.h and cgiutil.h
> for instance).

Sounds good.  But the .h files not need the UNUSED define.  It would
only be used in the .c files.

I created <URL:http://mapserver.gis.umn.edu/bugs/show_bug.cgi?id=1178>
with a patch to add this define.  I hope it is OK and will be
processed in time for 4.5. :)



More information about the mapserver-dev mailing list