Patch to fix MAX/MIN error introduced in Bug 1305

Daniel Morissette dmorissette at DMSOLUTIONS.CA
Fri May 13 09:47:19 EDT 2005


Frank Warmerdam wrote:
> On 5/13/05, Bill Binko <bill at binko.net> wrote:
>
>>I made this change a while ago, but it never got applied. Basically, I
>>added MAX() and MIN() macros not knowing about MS_MAX and MS_MIN, so this
>>removes them and uses the right ones in msdraw.c
>>
>>If someone could apply it, I'd appreciate it.
>
>
> Bill,
>
> Patch applied.
>
> Thanks,

Guys,

Would it not have been better to fix the code to use MS_MAX everywhere
instead of defining multiple macros to do the same thing?

My 0.02$

Daniel
--
------------------------------------------------------------
  Daniel Morissette               dmorissette at dmsolutions.ca
  DM Solutions Group              http://www.dmsolutions.ca/
------------------------------------------------------------



More information about the mapserver-dev mailing list