PHP Mapscript fixes for 4.6.0-beta2

[Mark Cave-Ayland]

Hi Bart,

Thanks for the advice, I wasn't sure exactly what to do with proposed
patches. I've just created an entry in Bugzilla for this
(http://mapserver.gis.umn.edu/bugs/show_bug.cgi?id=1367) and uploaded the
files contained in the original email.


Many thanks,

Mark.

------------------------
WebBased Ltd
South West Technology Centre
Tamar Science Park
Plymouth
PL6 8BT

T: +44 (0)1752 791021
F: +44 (0)1752 791023
W: http://www.webbased.co.uk


> -----Original Message-----
> From: Bart van den Eijnden [mailto:BEN at Syncera-ITSolutions.NL]
> Sent: 27 May 2005 08:10
> To: MAPSERVER-DEV at LISTS.UMN.EDU; Mark Cave-Ayland (External)
> Subject: Re: [UMN_MAPSERVER-DEV] PHP Mapscript fixes for 4.6.0-beta2
>
>
> Hi Mark,
>
> it might be the best idea to open up a bug report per fix in
> the Mapserver bugzilla so these patches don't get lost.
>
> I also don't know what the policy is for keeping SWIG
> mapscript in sync with PHP/Mapscript, so your changes might
> need changes in the SWIG mapscript as well.
>
> Best regards,
> Bart
>
> Bart van den Eijnden
> Syncera-ITSolutions
> Postbus 270
> 2600 AG  DELFT
>
> tel.nr.: 015-7512436
> email: BEN at Syncera-ITSolutions.nl
>
> >>> Mark Cave-Ayland <m.cave-ayland at WEBBASED.CO.UK> 05/26/05
> 03:08pm >>>
> Hi everyone,
>
> I've just been looking at dynamically creating symbols on the
> fly using PHP Mapscript, and found a couple of bugs which I
> believe I have fixed with the attached patches. The patches
> are against the file mapserver-4.6.0-beta2.tar.gz which I
> downloaded from http://mapserver.gis.umn.edu.
>
>
>         1) symbolObj has no imagepath property
>
>         This was fixed by copying the code from mapsymbol.c
> to allow the imagepath property to be set via mapscript. I
>         was a little unsure about how the current path should
> be handled, so at the moment it assumes that the path to the
>         GIF/PNG is absolute without considering the current
> path from the environment.
>
>         2) symbolObj->setPoints() doesn't correctly set
> symbolObj->sizex/sizey
>
>         Using setPoints() to load an array of points for a
> vector symbol was not correctly setting sizex/sizey to the
>         maximum extents of the symbol. Hence all symbols were
> being drawn with a size of 0 and did not appear to be
>         visible. This was fixed by borrowing the code from
> mapsymbol.c to set sizex/sizey to the maximum extents of the
>         symbol as points are added to the symbol.
>
>
> Many thanks,
>
> Mark.
>
> ------------------------
> WebBased Ltd
> 17 Research Way
> Plymouth
> PL6 8BT
>
> T: +44 (0)1752 797131
> F: +44 (0)1752 791023
> W: http://www.webbased.co.uk
>