Pixmap symbol scaling bug #1684: review and back porting

Daniel Morissette dmorissette at MAPGEARS.COM
Thu Mar 2 18:04:16 EST 2006

Jani Averbach wrote:
> This is broken with 4.8 but not with 4.6.
> And there is slight difference in behavior between 4.6 and 4.8.
> With 4.6 the SIZE controlled height, but with 4.8 SIZE controls 
> the biggest of dimensions, height or width depending which one is 
> bigger (mapgd.c: msDrawMarkerSymbolGD).
> So the behavior what Daryl is seeing now with cvs-head 
> is expected.

If there is a change of behavior then the docs will need to be updated 
to make the new behavior clear and to avoid this becoming another FAQ. 
In addition to updating the docs, could you please also describe the 
change of behavior in your HISTORY.TXT entries in both 4.8 and 4.9.

> If everyone is happy with the fix, I will back port this to 4.8.x 
> and close the bug #1684.

Since there's a change of behavior it's a bit more tricky, but if things 
were plain broken in 4.8 before then the fix with the new behavior is 
better than a broken feature, so based on the little information that I 
have on this I'd say go ahead with backporting.

Daniel Morissette

More information about the mapserver-dev mailing list