RFC-24 macros question

Daniel Morissette dmorissette at MAPGEARS.COM
Tue Jul 10 09:21:46 EDT 2007


Umberto Nicoletti wrote:
> I think that names are extremely important and picking great
> meaningful names is a valuable gift in programming.
> It's ok for me to change the macros, but I would retain the IS verb
> which means expect a boolean result:
> 
> #define MS_REFCNT_DECR_IS_NOT_ZERO(obj) (MS_REFCNT_DECR(obj))>0
> #define MS_REFCNT_DECR_IS_ZERO(obj) (MS_REFCNT_DECR(obj))<=0
> 
> Will you do the change?

Sounds great to me. I'll make the change and have created a ticket for it:
https://trac.osgeo.org/mapserver/ticket/2148

Thanks

Daniel
-- 
Daniel Morissette
http://www.mapgears.com/



More information about the mapserver-dev mailing list