[mapserver-dev] Re: postgis transaction patch (WAS: Voluminous Bug List)

[David Fuhry]

Paul,

    I've submitted v6 of the mappostgis.c patch to Trac.  It removes the 
deprecated postgis < 0.6 code and writes a message via msDebug() when 
the connection is being PQreset().

    I've notified a few testers about the update.  Based on my testing 
(cgi and the attached php & python scripts), unless additional problems 
can be found, it seems good to go.

Thanks,

Dave

Paul Ramsey wrote:
> On Mon, Apr 14, 2008 at 2:52 PM, David Fuhry <dfuhry at acm.org> wrote:
> 
>>  Done, and renamed the method msPOSTGISSanitizeConnection to better reflect
>> its purpose.  Find the updated patch in trac.
> 
> I'll take a look. Meanwhile, fire up your debugger :)
> 
>>  It would be nice to see that whole section in the end of prepare_database
>> removed, since AFAICT its only purpose is to support postgis <= 0.5, while
>> it drags around baggage & obscures the code while doing so.  Should that be
>> a separate patch, or included in this one?
> 
> You can do it at the same time. It is certainly disposable code.
> 
>>  Agreed.  Deferring to your judgment on how hex vs. binary performance would
>> play out, since there seem to be a lot of variables.
> 
> There will be a performance penalty, but I'll be happy to pay it for
> the cleaner code. Geoserver does it with text encoding of WKB, and
> that doesn't stop them from running faster than Mapserver on
> (carefully contrived :) benchmarks.
> 
> P
-------------- next part --------------
A non-text attachment was scrubbed...
Name: drawquery.py
Type: text/x-python
Size: 124 bytes
Desc: not available
Url : http://lists.osgeo.org/pipermail/mapserver-dev/attachments/20080420/b0621588/drawquery.py
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ms_test.php
Type: application/x-php
Size: 584 bytes
Desc: not available
Url : http://lists.osgeo.org/pipermail/mapserver-dev/attachments/20080420/b0621588/ms_test.bin