[mapserver-dev] Performance Patch

[Paul Ramsey]

Answer to my own question: -pedantic
However it mostly bitches about C++ style comments in C code. It did
find the mixed declarations that MSVC hated though.

P

On Sat, Apr 26, 2008 at 2:51 PM, Paul Ramsey <pramsey at cleverelephant.ca> wrote:
> Yes, MSVC is stricter than GCC on where you declare your variables, so
>  it's failing compile. Anyone know a magic flag I can set in GCC to
>  make it strict also? Easier to find these if my compiler complained
>  than kicking over the buildbot repeatedly...
>
>  Thanks Jeff,
>
>  P.
>
>
>
>  On Sat, Apr 26, 2008 at 9:20 AM, Jeff McKenna <jeffmckenna at gmail.com> wrote:
>  > Paul there seems to be some quirks with the patch & MSVC (with r7531) :
>  >
>  >  mapshape.c(1062) : error C2143: syntax error : missing ';' before 'type'
>  >  mapshape.c(1066) : error C2065: 'buffer' : undeclared identifier
>  >  mapshape.c(1066) : warning C4022: 'fread' : pointer mismatch for actual
>  > paramete
>  >  r 1
>  >  mapshape.c(1070) : error C2143: syntax error : missing ';' before 'type'
>  >  mapshape.c(1071) : error C2065: 'i' : undeclared identifier
>  >  mapshape.c(1078) : warning C4022: 'memcpy' : pointer mismatch for actual
>  > paramet
>  >  er 2
>  >  mapshape.c(1079) : warning C4022: 'memcpy' : pointer mismatch for actual
>  > paramet
>  >  er 2
>  >  mapshape.c(1106) : error C2143: syntax error : missing ';' before 'type'
>  >  mapshape.c(1131) : error C2143: syntax error : missing ';' before 'type'
>  >  mapshape.c(1133) : error C2065: 'shxBufferPage' : undeclared identifier
>  >  mapshape.c(1147) : error C2143: syntax error : missing ';' before 'type'
>  >  NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio
>  > 8\VC\BIN\c
>  >  l.EXE"' : return code '0x2'
>  >  Stop.
>  >
>  >
>  >  -jeff
>  >
>  >
>  >
>  >
>  >
>  >
>  >  On 25-Apr-08, at 5:12 PM, Paul Ramsey wrote:
>  >
>  >
>  > > So, for my first commit, I'd like to apply the very cool shape file
>  > > performance patch :)
>  > >
>  > > http://trac.osgeo.org/mapserver/ticket/2282
>  > >
>  > > However, as far as I know only Steve has tested it.  Surely someone
>  > > else has an existing map file that uses largish shape files and can do
>  > > a before-and-after?  Or has an app that does shapefile writing in
>  > > mapscript?
>  > >
>  > > Paul
>  > >
>  >  _______________________________________________
>  >  mapserver-dev mailing list
>  >  mapserver-dev at lists.osgeo.org
>  >  http://lists.osgeo.org/mailman/listinfo/mapserver-dev
>  >
>