[mapserver-dev] Single-pass query RFC updated...

Steve Lime Steve.Lime at dnr.state.mn.us
Tue Jun 9 17:11:35 EDT 2009


I'll update the RFC and call for a vote early next week (out fishing the rest of this week)...

Steve

>>> On 6/8/2009 at 12:27 PM, in message <4A2D4A0D.1090302 at mapgears.com>, Daniel
Morissette <dmorissette at mapgears.com> wrote:
> Steve Lime wrote:
>> I had thought about that. I think that will break more apps since most folks 
> only use msLayerGetShape() in
>> the context of queries. Which is worse? I do like the more explicit name of 
> msLayerResultSetGetShape(). 
>> 
> 
> Good point. However the apps that currently call GetShape in the context 
> of queries will need to be fixed to avoid calling open/close anyway, so 
> the change to use msLayerResultSetGetShape is just one more tiny change 
> for apps that will already be broken and require an update.
> 
> In a context where both approaches have side-effects, perhaps the better 
> name could be the reason to choose one over the other?
> 
> 
>> Note that for many drivers the  msLayerResultSetGetShape() would just wrap 
> msLayerGetShape() since
>> the result set indexes reference the main dataset. Shapefiles would work 
> like this. Any driver that didn't/couldn't
>> maintain a result set handle could do it this way and would work like do 
> now.
>> 
> 
> That's what I thought we would do for OGR.
> 
> Daniel



More information about the mapserver-dev mailing list