[mapserver-dev] MS RFC 90: Enable/Disable Layers in OGC Web Services by IP Lists - Call for Comments

[Daniel Morissette]

On 13-02-20 10:05 AM, Tamas Szekeres wrote:
> Hi Daniel & All,
>
> I've updated RFC-90 to follow the concept mentioned.
>
> http://mapserver.org/development/rfc/ms-rfc-90.html
>
> Here is a commit containing the proposed changes according to the recent
> version:
> https://github.com/szekerest/mapserver/commit/5d7ec08292e4b790d219082f7ea6ced83fc5c336
>

Thanks a lot Tamas... the RFC seems to address all my comments now.

BTW, I notice in your commit that you call msOWSLookupMetadata() twice 
in msOWSIpDisabled():


   ip_list = msOWSLookupMetadata(metadata, namespaces, "allowed_ip_list");

   if (!ip_list)
     ip_list = msOWSLookupMetadata(metadata, "O", "allowed_ip_list");

I'm not sure why you do this. FYI the idea behind msOWSLookupMetadata() 
is that all places that pass a "namespaces" arg should include the "O" 
as the last argument in the string... so your second call with the "O" 
is redundant unless I'm mistaken since the namespaces in the previous 
call should contain an "O" already.


-- 
Daniel Morissette
http://www.mapgears.com/
Provider of Professional MapServer Support since 2000