[mapserver-dev] Disabled layers are re-enabled by wms_layer_group setting (Bug or feature?)

[Stephan Meißl]

Tamas,

seems you hit issue #4533. I had an initial look at it but I'm currently
under heavy load and I'm afraid it has to wait a bit longer unless you
want to give it a try?

Sorry,
Stephan


On 02/26/2013 09:31 AM, Tamas Szekeres wrote:
> Hi All,
> 
> Related to the tests of RFC-90 we found an issue when a layer is
> disabled by IP list, but for the GetCapabilities request the layer is
> re-enabled when the layer is a part of a wms_layer_group. For example
> with the following setting:
> 
> 
> LAYER
>    NAME Layer1
>    METADATA
>       "ows_allowed_ip_list" "*"
>       "wms_layer_group" "/Layer1"
>    END
> END
> 
> LAYER
>    NAME Layer2
>    METADATA
>       "ows_allowed_ip_list" "!*"
>       "wms_layer_group" "/Layer1"
>    END
> END
> 
> Both Layer1 and Layer2 are displayed in GetCapabilities. The same
> applies when the layer is completely disabled for GetCapabilities by
> enable_request, like:
> 
> 
> LAYER
>    NAME Layer1
>    METADATA
>       "wms_enable_request" "GetCapabilities"
>        "wms_layer_group" "/Layer1"
>    END
> END
> 
> LAYER
>    NAME Layer2
>    METADATA
>       "wms_enable_request" "!GetCapabilities"
>       "wms_layer_group" "/Layer1"
>    END
> END
> 
> Both Layer1 and Layer2 are displayed.
> 
> Is this a feature or an issue that should be fixed?
> 
> 
> Best regards,
> 
> Tamas
> 
> 
> 
> 
> 
> 2013/2/21 Daniel Morissette <dmorissette at mapgears.com
> <mailto:dmorissette at mapgears.com>>
> 
>     On 13-02-20 10:05 AM, Tamas Szekeres wrote:
> 
>         Hi Daniel & All,
> 
>         I've updated RFC-90 to follow the concept mentioned.
> 
>         http://mapserver.org/__development/rfc/ms-rfc-90.html
>         <http://mapserver.org/development/rfc/ms-rfc-90.html>
> 
>         Here is a commit containing the proposed changes according to
>         the recent
>         version:
>         https://github.com/szekerest/__mapserver/commit/__5d7ec08292e4b790d219082f7ea6ce__d83fc5c336
>         <https://github.com/szekerest/mapserver/commit/5d7ec08292e4b790d219082f7ea6ced83fc5c336>
> 
> 
>     Thanks a lot Tamas... the RFC seems to address all my comments now.
> 
>     BTW, I notice in your commit that you call msOWSLookupMetadata()
>     twice in msOWSIpDisabled():
> 
> 
>       ip_list = msOWSLookupMetadata(metadata, namespaces,
>     "allowed_ip_list");
> 
>       if (!ip_list)
>         ip_list = msOWSLookupMetadata(metadata, "O", "allowed_ip_list");
> 
>     I'm not sure why you do this. FYI the idea behind
>     msOWSLookupMetadata() is that all places that pass a "namespaces"
>     arg should include the "O" as the last argument in the string... so
>     your second call with the "O" is redundant unless I'm mistaken since
>     the namespaces in the previous call should contain an "O" already.
> 
> 
> 
>     -- 
>     Daniel Morissette
>     http://www.mapgears.com/
>     Provider of Professional MapServer Support since 2000
> 
>     _________________________________________________
>     mapserver-dev mailing list
>     mapserver-dev at lists.osgeo.org <mailto:mapserver-dev at lists.osgeo.org>
>     http://lists.osgeo.org/__mailman/listinfo/mapserver-dev
>     <http://lists.osgeo.org/mailman/listinfo/mapserver-dev>
> 
> 
> 
> 
> _______________________________________________
> mapserver-dev mailing list
> mapserver-dev at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/mapserver-dev
>