[mapserver-dev] SWIG Changes for 7.4

[Seth G]

Hi Andy,

The pull request in the MapServer queue looks good to me.

For the additions at https://github.com/AndyColson/mapserver/commit/96ccb182b6750c7236c0448698dafc744e8c3eab there are quite a few whitespace/formatting differences which make it hard to see the actual changes. 
The NULL check looks fine in image.i
For the removal of #ifdef SWIGPYTHON in msio.i - I presume this is to have the same feature in Perl? Do the C# and PHP bindings build successfully with this change? If so it seems fine to include it (otherwise I think you could use #if defined(SWIGPYTHON) || defined(SWIGPERL5) )

Seth

--
web:http://geographika.co.uk
twitter: @geographika

On Sun, Apr 14, 2019, at 10:47 PM, Andy Colson wrote:
> On 4/14/19 3:01 PM, Andy Colson wrote:
> > I know its pretty late in the game, but while testing perl mapscript, I found two little changes I'd like to make.
> > 
> > Should I
> > 1) add it to my existing pull request
> > 2) create a new branch, and new pull request for 7.4
> > 3) its too late for 7.4, wait
> > 
> > I have perl test's that use the swig changes, so I can't add them yet either.
> > 
> > -Andy
> 
> So that you can see the changes:
> 
> https://github.com/AndyColson/mapserver/commit/96ccb182b6750c7236c0448698dafc744e8c3eab
> 
> 
> 
> _______________________________________________
> mapserver-dev mailing list
> mapserver-dev at lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/mapserver-dev