[mapserver-users] Label wrapping question

[Dejan Gambin]

Here it is: https://github.com/mapserver/mapserver/pull/5033

regards, dejan

On 6. stu. 2014., at 22:27, Lime, Steve D (MNIT) wrote:

> Dejan: If you'd open a ticket with your patches or submit a pull request it would be appreciated. --Steve
> 
> -----Original Message-----
> From: mapserver-users-bounces at lists.osgeo.org [mailto:mapserver-users-bounces at lists.osgeo.org] On Behalf Of Dejan Gambin
> Sent: Thursday, November 06, 2014 7:34 AM
> To: Rahkonen Jukka
> Cc: 'mapserver-users at lists.osgeo.org'
> Subject: Re: [mapserver-users] Label wrapping question
> 
> Hi Jukka,
> 
> If you remember, I've sent the screen captures. I am just interested if this change makes sense and do you plan to embed it in the future versions? 
> 
> Like I said, this is just the proof of concept. I didn't make change for label->encoding part, and also, it currently crashes in certain situation if I have a word in label text longer than maxlength. It should all be revised and modified.
> 
> Thanks very much
> 
> regards, dejan
> On 24. ruj. 2014., at 15:15, Rahkonen Jukka (Tike) wrote:
> 
>> Hi,
>> 
>> Send us some screen captures  of wrapped labels before and after your change. I feel that your change would make sense.
>> 
>> -Jukka Rahkonen-
>> 
>> Dejan Gambin wrote:
>> 
>>> In the meantime, I have slightly changed msWrapText() function in 
>>> maplabel.c to get what I wanted. If someone is interested I can share the short piece of code.
>>> 
>>> regards, dejan
>>> 
>>> 
>>> On 23. ruj. 2014., at 12:32, Dejan Gambin wrote:
>>> 
>>>> Hi,
>>>> 
>>>> I have some users wishing to use long legend labels, but they don't 
>>>> fit well on
>>> my site. As I can see, MapServer is doing this - if maxlength > 0 and wrap = 'char'
>>> (usually space), insert a new line at the FIRST wrap character found 
>>> AFTER maxlength character. This is leading to some bad results (label 
>>> not wrapped or wrapped too early).
>>>> 
>>>> My question is - shouldn't it be better to wrap at the LAST wrap 
>>>> character
>>> BEFORE maxlength character? Is this maybe implemented somewhere or 
>>> there are plans for this?
>>>> 
>>>> Thanks very much
>>>> 
>>>> regards, dejan
>>>> _______________________________________________
>>>> mapserver-users mailing list
>>>> mapserver-users at lists.osgeo.org
>>>> http://lists.osgeo.org/mailman/listinfo/mapserver-users
>>> 
>>> _______________________________________________
>>> mapserver-users mailing list
>>> mapserver-users at lists.osgeo.org
>>> http://lists.osgeo.org/mailman/listinfo/mapserver-users
> 
> _______________________________________________
> mapserver-users mailing list
> mapserver-users at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/mapserver-users