[MapServer-users] breaking changes in branch-7-6 after commit of experimental changes from branch-8-0

[Rahkonen Jukka]

Hi,

It looks like Steve Lime was reading the text in the paragraph and not the line the defines the synopsis and thought that the documentation was explicit  https://github.com/MapServer/MapServer/issues/6463#issuecomment-1025938850
“since style-level angle documentation refers specifically to 0-360 I think we should limit from 0-360 if there are no objections”. Or maybe he was remembering what he was thinking when writing the original code?

Please make a pull request for improving the documentation, for my mind it is vague now.

-Jukka Rahkonen-



Lähettäjä: Oliver Christen <oliver.christen at camptocamp.com>
Lähetetty: tiistai 30. toukokuuta 2023 15.21
Vastaanottaja: Rahkonen Jukka <jukka.rahkonen at maanmittauslaitos.fi>
Kopio: mapserver-users at lists.osgeo.org
Aihe: Re: [MapServer-users] breaking changes in branch-7-6 after commit of experimental changes from branch-8-0

before that commit, the following code was working:

    STYLE
      COLOR 255 255 255
      SYMBOL "rectangle3"
      ANGLE -45
      SIZE 8
      GAP 10
    END

after that commit, it no longer works, as ANGLE -45 is not accepted anymore, instead it had to be changed to

STYLE
      COLOR 255 255 255
      SYMBOL "rectangle3"
      ANGLE 315
      SIZE 8
      GAP 10
    END

the documentation https://mapserver.org/mapfile/style.html say it must be of type DOUBLE, but double can be negative and nothing say explicitly in the documentation that the value can not be negative.

I see this discussion here:
https://github.com/MapServer/MapServer/issues/6463
but no comment if something was done or agreed on about this.
A note should be added to the documentation to make that clear, as it was done for label size (see below).
I can do a PR if that would be acceptable ?

for label size, I see that a note was added saying the value must be greater than zero on 26 january 2022, so I guess this is on me for not noticing it (but im not alone not noticing it so I guess it wasnt clearly stated/announced either)

Best regards
Oliver






On Tue, May 30, 2023 at 1:27 PM Rahkonen Jukka <jukka.rahkonen at maanmittauslaitos.fi<mailto:jukka.rahkonen at maanmittauslaitos.fi>> wrote:
Hi,

Maybe the commit could be adjusted in Mapserver 7. Out of curiosity, what is the use case for zero sized labels and symbols? To disable them, or? About the angle, by the Mapserver 7.0 documentation, doesn’t it feel like negative angles were not thought to work ever?

“Angle, given in degrees, to rotate the symbol (counter clockwise). Default is 0 (no rotation). If you have an attribute that specifies angles in a clockwise direction (compass direction), you have to adjust the angle attribute values before they reach MapServer (360-ANGLE), as it is not possible to use a mathematical expression for ANGLE.”

-Jukka Rahkonen-

Lähettäjä: MapServer-users <mapserver-users-bounces at lists.osgeo.org<mailto:mapserver-users-bounces at lists.osgeo.org>> Puolesta Oliver Christen
Lähetetty: tiistai 30. toukokuuta 2023 13.59
Vastaanottaja: mapserver-users at lists.osgeo.org<mailto:mapserver-users at lists.osgeo.org>
Aihe: [MapServer-users] breaking changes in branch-7-6 after commit of experimental changes from branch-8-0

Dear Mapserver commiters

this commit there:
https://github.com/MapServer/MapServer/pull/6818

broke a lot of things,
like style angles not supporting negative values anymore or label size mandatorily greater than zero (also possibly for symbol)

Im not against changes, but changes should be:
a) documented
b) announced with preferably a deprecation period

so, please revert that commit or provide adequate change/documentation for all the breaking changes.

Thank you
Best regards
Oliver Christen

--


[https://lh5.googleusercontent.com/4RpzNqlUvMoqWPtwuUWigz1_dKPkUN4OQOKshy_zixf9Gi6JzQJRjs3oHwxYaiADK7htQjUTodRa-OUr4YEKbgs9SsmqPG6QYjqKj3wbXoQ6snhaqq2eEJTeB1FZHKK7SApWcSZk45Fe3w4grA]<https://www.camptocamp.com/en/news-events/camptocamp-flagship-office-bussigny>

New address from 1st September 2022


Camptocamp SA

Route de la Chaux 4

1030 Bussigny

Suisse
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/mapserver-users/attachments/20230530/a108a17d/attachment-0001.htm>