[OpenLayers-Dev] Review of patches, etc.
jachym.cepicky at gmail.com
Sat Dec 15 07:04:08 EST 2007
it speeds up the development - do not fear and go ahead. People do
usually distinguish between small patch and big change - they will
break something only sometimes :-)
Christopher Schmidt píše v Pá 14. 12. 2007 v 07:52 -0500:
> I'm beginning to think I was a bit overzealous in stating that all
> patches should require an external review. I've been watching OpenLayers
> development lately, and although I agree that in principle, code review
> is a good thing, I think that it has seriously hamstrung the project
> over the past couple months, due to lack of development time from a few
> core committers who were able to help move things forward in the past.
> Getting more core committers is one helpful step in the right direction,
> but it doesn't completely solve the problem: we're still blocking on
> very simple (one line) patches due to lack of review.
> I'd like to float the idea of allowing commits to trunk without review
> at the discrestion of the patch author. We've got really great
> committers, and I think we have the ability to decide when things
> should/shouldn't go in without a review on every patch.
> That said, when API functionality is involved, I think more thna one
> person should be able to comment before it goes into trunk. So, I think
> that any patch which adds new APIMethods or APIProperties should
> probably be opened as a ticket, and comments should be sought on it
> before it goes into trunk. Additionally, we should be more proactive in
> discussing things both in tickets nd on the mailing lists when there is
> a suggestion in API change.
> How do other people feel about this? I don't want to continue to see one
> line patches left open for 6 months due to lack of review.
e-mail: jachym.cepicky at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Toto je =?UTF-8?Q?digit=C3=A1ln=C4=9B?=
Url : http://lists.osgeo.org/pipermail/openlayers-dev/attachments/20071215/6ac9dd23/attachment.bin
More information about the Dev