[OpenLayers-Dev] Review of patches, etc.

Paul Spencer pspencer at dmsolutions.ca
Sat Dec 15 08:17:22 EST 2007


I think this is a good idea.  I think the benefits of attracting more  
contribution are worth giving a little on process.


On 14-Dec-07, at 7:52 AM, Christopher Schmidt wrote:

> I'm beginning to think I was a bit overzealous in stating that all
> patches should require an external review. I've been watching  
> OpenLayers
> development lately, and although I agree that in principle, code  
> review
> is a good thing, I think that it has seriously hamstrung the project
> over the past couple months, due to lack of development time from a  
> few
> core committers who were able to help move things forward in the past.
> Getting more core committers is one helpful step in the right  
> direction,
> but it doesn't completely solve the problem: we're still blocking on
> very simple (one line) patches due to lack of review.
> I'd like to float the idea of allowing commits to trunk without review
> at the discrestion of the patch author. We've got really great
> committers, and I think we have the ability to decide when things
> should/shouldn't go in without a review on every patch.
> That said, when API functionality is involved, I think more thna one
> person should be able to comment before it goes into trunk. So, I  
> think
> that any patch which adds new APIMethods or APIProperties should
> probably be opened as a ticket, and comments should be sought on it
> before it goes into trunk. Additionally, we should be more proactive  
> in
> discussing things both in tickets nd on the mailing lists when there  
> is
> a suggestion in API change.
> How do other people feel about this? I don't want to continue to see  
> one
> line patches left open for 6 months due to lack of review.
> Regards,
> -- 
> Christopher Schmidt
> MetaCarta
> _______________________________________________
> Dev mailing list
> Dev at openlayers.org
> http://openlayers.org/mailman/listinfo/dev

|Paul Spencer                          pspencer at dmsolutions.ca    |
|Chief Technology Officer                                         |
|DM Solutions Group Inc                http://www.dmsolutions.ca/ |

More information about the Dev mailing list