[OpenLayers-Dev] Different lon and lat map resolution (and other issues)

Jachym Cepicky jachym.cepicky at gmail.com
Fri Nov 2 12:11:01 EDT 2007


Tim Schaub píše v Pá 02. 11. 2007 v 09:43 -0600:
> Hey-
> Just a quick note to say I understand your frustration.  However, we all 
> have lots of work to do - and it doesn't make sense to allow 
> modifications willy-nilly.

I can understand this. How many people do have write access to trunk?

> http://trac.openlayers.org/query?status=new&status=assigned&status=reopened&keywords=%7Ereview&order=priority
> (or http://tinyurl.com/3yvr56 if you like)
> The above link shows the current patches awaiting review.  Now, I can't 
> speak for others, but I generally don't take on patch review unless:
> 1) a ticket really makes sense to me
> 2) the ticket has a single (obvious unified diff) patch for review
> 3) the patch includes some tests

what do you understand with "test" ? Is it working demo? 

> It's probably best if your idea gets some air time.  If there are others 
> that are interested in it, then the issue likely deserves some 
> attention.  If nobody else wants the modification, then it's probably 
> not suited for the library.

Well, IMHO, usually, if people do agree with something, they likely say
nothing. People are only raising their hands, if they want to complain.
I had one positive feedback from one user (off-list), that it is usable.
It solves my problem - it *could* solve also other people problems. 

IMHO, the patch with new feature should be accepted always, unless there
is some serious reason for not accepting it. Patches in general are
supposed to add new features - make the software more customizable for
everyones needs. If now I'm the only one, who needs it, who can say,
there will be nobody in the future?

And - I'm posting this to dev list only. Should I post to users list as
well, to get some kind of support?

> If there is interest from others (replies to the list, comments on the 
> patch), then it would probably make sense to add some tests and make a 
> single patch for your modification.  And yes, if it doesn't apply to the 
> trunk, it is even less likely to get reviewed.

If I understand your last sentence right - we are expected to keep our
patches fresh for several weeks or months? If so, I would have to ask,
if there could be some better development model(?).

It is not going only about this one issue - I have several other
improvements, Marker/Label.js, Popup.js, LayerSwitcher.js and others.
But I'm asking myself, if it is worth the work, to prepare patches, if
nobody even reviews them :-(

Thanks for your answers


> Tim
> Jachym Cepicky wrote:
> > Hi,
> > I submitted new patch set to #889 [1], which implements different pixel
> > resolutions in x and y direction. The patches should work with *current*
> > version of OpenLayers.
> > 
> > I would also like to ask several questions:
> >  - when approximately the patch will be added to trunk, or 
> >  - when approximately will be decided, this will/will not happen
> >  - what else can I / do I have to do for, the patch will be accepted or
> > definitely declined
> >  - do I have to prepare fresh patches let say every week, so they are
> > still usable for current OpenLayers, or is it enough, post them once,
> > the project managers will update them by themselves? 
> > 
> > Now, I did 3rd version of the patch, till now, there was even no
> > discussion, if the patch should/should not/should under some conditions
> > be accepted/declined. 
> > 
> > Sorry, if this sounds rude - this e-mail is not to be understood as
> > blame. It is just little bit frustrating: If the people are asking for
> > new features, most general answer is "patches are welcomed". If the
> > patches are there, nobody wants them. Or, so it looks at least from
> > here. That is, why I'm asking about the mechanisms of patch
> > acceptation. 
> > 
> > Thanks
> > 
> > Jachym
> > 
> > [1] http://trac.openlayers.org/ticket/889
> > 
> > 
> > ------------------------------------------------------------------------
> > 
> > _______________________________________________
> > Dev mailing list
> > Dev at openlayers.org
> > http://openlayers.org/mailman/listinfo/dev
> > 
> > 
> > !DSPAM:4033,472b3b42219125210051143!
> _______________________________________________
> Dev mailing list
> Dev at openlayers.org
> http://openlayers.org/mailman/listinfo/dev
Jachym Cepicky
e-mail: jachym.cepicky at gmail.com
URL: http://les-ejk.cz
GPG: http://www.les-ejk.cz/pgp/jachym_cepicky-gpg.pub

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Toto je =?UTF-8?Q?digit=C3=A1ln=C4=9B?=
	=?ISO-8859-1?Q?_podepsan=E1?= =?UTF-8?Q?_=C4=8D=C3=A1st?=
Url : http://lists.osgeo.org/pipermail/openlayers-dev/attachments/20071102/cd1ac663/attachment.bin

More information about the Dev mailing list