[OpenLayers-Dev] Code Sprint: SLD

Christopher Schmidt crschmidt at metacarta.com
Tue Oct 2 09:03:31 EDT 2007

On Tue, Oct 02, 2007 at 04:12:39PM +0900, Andreas Hocevar wrote:
> I finally figured out a way to build an object tree with rules,
> including all requirements like recursively stacking logical
> operators.


I read through your code last night, and was quite pleased with the
result you had come up with. I saw it go into trunk and immediately read
through it -- quite happy with the result. Thanks for the hard work on

> I hope the progress I made will make it easier for you to move this
> sld thing into trunk.

So, I would like to see at least a few tests before we bring it back
into trunk:
 * Minimal constructor tests for any new classes
 * A test or two for each of the Rule.Foo subclasses, if possible
 * A minimal test for pulling in SLD.
   * Do we write out SLD from rules? if so, a round-trip test would be
     nice to have too -- read in, write out, compare to expected

Nothing too complex -- just enough to build a framework so that future
bugfixes can build on top of it.

Christopher Schmidt

More information about the Dev mailing list