[OpenLayers-Dev] jslint cleanup committed

Erik Uzureau erik.uzureau at metacarta.com
Thu Oct 18 13:28:54 EDT 2007

I agree that the firebug files we should leave as-is so we can make
upgrading easier (though it would certainly be worth posting a cleanup
patch to their project. do onto others...)

regarding the rico bits, I say "yes". We've modified them pretty
significantly anyways, and I think we're now using them for everything
we'll ever need from them. Which is to say, the only reason they're in
there is for rounded corners, and I don't anticipate great leaps of
innovation in the world of corner rounding. So yeah, let's go ahead
and clean that up.

Thanks so much for your work on this, Paul. r5002 is a great patch, a
non-functional but professionalizing step forward. Muito muito


On 10/18/07, Christopher Schmidt <crschmidt at metacarta.com> wrote:
> On Thu, Oct 18, 2007 at 09:01:57AM -0400, Paul Spencer wrote:
> > I have added missing semi-colons and curly braces around all block
> > scopes in:
> >
> > http://trac.openlayers.org/changeset/5002/
> >
> > jslint reports the remaining warnings:
> >
> > /lib/Firebug/firebug.js: 0 error(s), 45 warning(s)
> > /lib/Firebug/firebugx.js: 0 error(s), 2 warning(s)
> > /lib/Rico/Color.js: 0 error(s), 18 warning(s)
> > /lib/Rico/Corner.js: 0 error(s), 36 warning(s)
> >
> > Do you want me to do anything about these?
> I would prefer we leave the firebug files alone -- I don't think we've
> touched those at all.
> I have no strong feelings on Rico: we've already changed those files to
> put them in the OpenLayers namespace, further changes don't bother me
> much, but I'm also happy to just leave them.
> Regards,
> --
> Christopher Schmidt
> MetaCarta
> _______________________________________________
> Dev mailing list
> Dev at openlayers.org
> http://openlayers.org/mailman/listinfo/dev

More information about the Dev mailing list