[OpenLayers-Dev] Ticket #1093
crschmidt at metacarta.com
Fri Jan 30 07:09:35 EST 2009
On Fri, Jan 30, 2009 at 09:31:07AM +0100, Patrick Valsecchi wrote:
> Thank you very much for this thorough answer.
> I'll take all those tips in concideration the next time I'll have a ticket to
> write for OL.
> I'm happy to ear the time to commit has been improved for OL, I hope I'll have
> the occasion to test that in the future. ;-)
I don't think it has improved. In fact, if anything, it has gotten worse
in the past 6 months. But the time to approve good, clean, simple
patches has *always* been relatively low, and I don't see any reason to
expect that to change.
Not all patches can be good, clean, and simple -- but the first two are
usually possible, and should be the target for anyone who wants to see
their changes integrated.
> As of asking directly my co-workers, I prefer not to, expect for simple
> comment fixes that don't require tickets. The point of the code review is to
> make sure the change serves everybody's interest and not only one's company.
Not at all! That is the job of the PSC in guiding the project. The point of
code review is simple: it is to make sure that two pairs of eyes look
over every chunk of code. One chunk of code isn't enough to catch all
errors, but two tends to catch the most egrarious errors.
Larger patches require more eyes, in general, but that tends to happen
The code review is designed to protect tecnical integrity. The social
aspects of 'Should OpenLayers be doing this?' should be managed by the
PSC -- and given the level of technical involvement by our PSC in the
process, I have no doubt that they are perfectly capable of managing
this aspect for themselves.
More information about the Dev