[OpenLayers-Dev] Thoughts about #2318: move pink tiles to css
Tim Schaub
tschaub at opengeo.org
Mon Oct 26 19:03:43 EDT 2009
Christopher Schmidt wrote:
> On Mon, Oct 26, 2009 at 11:47:59AM +1100, Roald de Wit wrote:
>> Hi list,
>>
>> During the FOSS4G 2009 codesprint I worked on ticket #2318 [1], which
>> has been committed to trunk. It is now possible to fully control the
>> looks of a broken image using CSS. The change also involves setting the
>> src of the broken image to a blank.gif. There is one drawback with this
>> last addition: you cannot right-click on the image anymore to see a
>> possible server error (since the src URL has changed).
>
> ^^ This is a *huge* problem in my mind. Pink tiles being right clickable
> is a big deal to me, and I'd like to see it change. I'm not 100% sure
> I understand the reason that this is required (I haven't looked at the code),
> but if there is no way to do this without losing the right click behavior,
> we at least need to make it an option (and I'd prefer one defaulting to the
> same as it does currently).
>
Yeah, I'd suggest separating these issues. Looking at the changeset
(http://trac.openlayers.org/changeset/9758), I'm guessing setting the
image source was not required by the issue discussed in the ticket.
If setting the image source to blank.gif is meant to get rid of the
broken image icon in some browsers, that deserves a separate ticket (and
I agree we need to maintain the current behavior that lets you get the URL).
Tim
> -- Chris
>
>> Is this behaviour something we can live with or would it be better to
>> keep the src URL pointing to the original image?
>>
>> Regards, Roald
>>
>> [1] http://trac.openlayers.org/ticket/2318
>>
>> --
>> Roald de Wit
>> Software Engineer
>> roald.dewit at lisasoft.com
>>
>> Commercial Support for Open Source GIS Software
>> http://lisasoft.com/LISAsoft/SupportedProducts/
>>
>>
>>
>> The contents of this email are confidential and may be subject to legal or professional privilege and copyright. No representation is made that this email is free of viruses or other defects. If you have received this communication in error, you may not copy or distribute any part of it or otherwise disclose its contents to anyone. Please advise the sender of your incorrect receipt of this correspondence.
>> _______________________________________________
>> Dev mailing list
>> Dev at openlayers.org
>> http://openlayers.org/mailman/listinfo/dev
>
--
Tim Schaub
OpenGeo - http://opengeo.org
Expert service straight from the developers.
More information about the Dev
mailing list