[OpenLayers-Dev] Re: More undefined variables on OpenLayers!

[christopher.schmidt at nokia.com]

Xavier,

The first step for closure integration was to integrate it as a build tool.
I am supportive of other developers who are interested taking on the integration
(and more importantly, *documentation*) of how to use Closure Compiler as a 
tool for finding warnings -- in the same way that developers currently use 
jslint to find errors and mistakes.

At this point, I do not have the time to invest in understanding closure enough
to integrate your changes in a way that I can understand how to use them, and
your patches did not make it clear to me how I would use closure to find these
warnings. (As I said in comments on the ticket, I think that the work you've
done is interesting, but I just don't understand it.)

If other developers are interested in taking it on, they're welcome to, obviously.
I just knew that I wasn't going to invest in it, and no one else expressed a 
strong interest at the time, so I bumped it.

-- Chris

On Mar 8, 2011, at 3:58 AM, ext Xavier Mamano (jorix) wrote:

> Hi Tim Schaub,
> 
> I think it would be interesting if any developer could easily use the
> Closure Compiler in this way as part of the tests. 
> For this reason I investigated the use of Closure and wrote #2972 and later
> http://trac.osgeo.org/openlayers/ticket/3008.
> (the current implementation of Closure in OL not allow this use, and should
> be reviewed: does not work on Windows see #3158)
> 
> Now #3008 is Milestone Future. I think it would be interesting to implement
> some of its parts in 2.11
> 
> Regards,
> 
> Xavier Mamano
> 
> 
> Tim Schaub wrote:
>> 
>> On 3/7/11 2:29 PM, Xavier Mamano (jorix) wrote:
>>> Hi,
>>> 
>>> Using Closure Compiler is possible to have a report of all undefined
>>> variables.
>>> 
>>> Now this is the result:
>>> 
>>> ...
>>> ..\lib\OpenLayers\Layer\Grid.js:704: ERROR - variable tlViewPort is
>>> undefined
>>> tlViewPort = tlLayer.add(offsetX, offsetY);
>>> ^
>> 
>> http://trac.osgeo.org/openlayers/changeset/11663/
>> 
>>> ..\lib\OpenLayers\Map.js:1692: ERROR - variable yRestriction is undefined
>>> var xRestriction = yRestriction = 0;
>>> . . . . . . . . . .^
>> 
>> http://trac.osgeo.org/openlayers/changeset/11664/
>> 
>>> ..\lib\OpenLayers\Renderer\SVG2.js:655: ERROR - variable component is
>>> undefined
>>> component = components[i];
>>> ^
>> 
>> http://trac.osgeo.org/openlayers/changeset/11665/
>> 
>>> 3 error(s), 26 warning(s)
>> 
>> Thanks for the vigilance.
>> Tim
>> 
>>> 
>>> (now is not possible get this report using "build.py -c closure")
>>> 
>>> Xavier Mamano
>>> 
>>> 
>>> 
>>> 
>>> --
>>> View this message in context:
>>> http://osgeo-org.1803224.n2.nabble.com/More-undefined-variables-on-OpenLayers-tp6099332p6099332.html
>>> Sent from the OpenLayers Dev mailing list archive at Nabble.com.
>>> _______________________________________________
>>> Dev mailing list
>>> Dev at lists.osgeo.org
>>> http://lists.osgeo.org/mailman/listinfo/openlayers-dev
>> 
>> 
>> -- 
>> Tim Schaub
>> OpenGeo - http://opengeo.org
>> Expert service straight from the developers.
>> _______________________________________________
>> Dev mailing list
>> Dev at lists.osgeo.org
>> http://lists.osgeo.org/mailman/listinfo/openlayers-dev
>> 
> 
> 
> --
> View this message in context: http://osgeo-org.1803224.n2.nabble.com/More-undefined-variables-on-OpenLayers-tp6099332p6115872.html
> Sent from the OpenLayers Dev mailing list archive at Nabble.com.
> _______________________________________________
> Dev mailing list
> Dev at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/openlayers-dev