[OpenLayers-Dev] Please review this patch (Script protocol)

[christopher.schmidt at nokia.com]

Volker,

Have you tested this patch with the GeoCouch stuff you're using?
If it works there, can you add a comment to that ticket? I think
in general it looks fine, though it would be nice to have some 
tests of some sort to confirm that this is doing what we want. Actually,
it looks like this patch *breaks* tests; I tossed together
https://github.com/crschmidt/openlayers-1/commit/6f4be895e292c98d7773bd7be2e0b4f71941a640.patch
which has a fix for the tests as well.

If you can test this, and add a comment to the ticket, I think it's
sane to go ahead with committing at that point.

-- Chris

On Sep 7, 2011, at 7:18 AM, ext Volker Mische wrote:

> On 09/07/2011 08:59 AM, Javier Carrasco wrote:
>> The script protocol is not working with Twitter service because of the
>> brackets in the generated requests url.
>> 
>> I just created a ticket and submitted a very small patch here
>> 
>> http://trac.osgeo.org/openlayers/ticket/3486
>> 
>> Thank you for reviewing it
>> 
>> Javi
> 
> Hi Javi,
> 
> looks good to me. I haven't tested it, but only read the source.
> 
> It's sad that OpenLayers 2.11 is almost out already. I would love to squeeze it in, but I can understand if it won't. 2.11 introduces the Script protocol and it would be cool if it won't need to change for 2.12, but it looks like it needs to.
> 
> Cheers,
>  Volker
> _______________________________________________
> Dev mailing list
> Dev at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/openlayers-dev