[OpenLayers-Trac] Re: [OpenLayers] #2835: Panel Control: Panel is displayed after deactivate

OpenLayers trac-20090302 at openlayers.org
Thu Oct 14 18:34:23 EDT 2010

#2835: Panel Control: Panel is displayed after deactivate
  Reporter:  jorix          |       Owner:              
      Type:  bug            |      Status:  closed      
  Priority:  minor          |   Milestone:  2.11 Release
 Component:  Control.Panel  |     Version:  2.10        
Resolution:  fixed          |    Keywords:              
     State:  Complete       |  

Comment(by jorix):

 Replying to [comment:6 ahocevar]:
 > We had to partially revert r10732 with r10834. The deactivate sequence
 is still fixed, but the destroy sequence should be fixed as part of #2210.
 Here we have crossed several tickets: r10813 changed the test that failed
 due to #2850 due to an oversight of mine in #2835 where he said:
   var div = panel.div;
   t.ok(panel.div.innerHTML == "".

 had to say:
   var div = panel.div;
   t.ok(div.innerHTML == "",

 but r10732 put:
   var div = panel.div;
   t.eq(panel.div, null,

 is not the same (this is a test that #2850 is fixed).

 But r10790 undo fix #2850, and test changet by r10813 failed.

 this looks like a scene from the '''Marx Brothers'''.

 #2850, is ok (and test {{{... div.innerHTML == "", ...}}} works with
 this.deactivate() in  panel destroy, with or without #2850).[[BR]]
 The original patch from #2864 and mine working properly with the right
 test, but they are different views of the problem (I thought of something
 like #2210)[[BR]]
 And #2210 is ok.


 Happy ending? :-))

Ticket URL: <http://trac.openlayers.org/ticket/2835#comment:7>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer

More information about the Trac mailing list