[OpenLayers-Trac] Re: [OpenLayers] #3400: Feature modification management

OpenLayers trac-20090302 at openlayers.org
Mon Jul 4 03:25:31 EDT 2011

#3400: Feature modification management
 Reporter:  ahocevar     |       Owner:  tschaub     
     Type:  feature      |      Status:  new         
 Priority:  minor        |   Milestone:  2.12 Release
Component:  Format.WFST  |     Version:  2.10        
 Keywords:               |       State:  Review      

Comment(by bartvde):

 Hey Andreas,

 a few remarks:

  * modified, shouldn't we call this originals or originalValues instead?
 To me the modified term sounds misleading, since I would expect it to have
 the modified values instead and not the originals?
  * with tests/Format/WFST/v1.html I would expect only the geometry to be
 written out, since it is the only one in modified? Why are the 2
 attributes written out as well? I see it in the code (the check for
 feature.attributes), but it's not what I would expect to happen. Or is
 this to be backwards-compatible? I guess so, but maybe state it somewhere
 in a comment?
  * tests/Control/ModifyFeature.html: layer.addFeatures[feature] is missing
  * lib/OpenLayers/Format/WFST/v1.js: should we not also check if the
 original and modified values differ?

 Respective tests also pass in FF4.

Ticket URL: <http://trac.openlayers.org/ticket/3400#comment:3>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer

More information about the Trac mailing list