[OpenLayers-Trac] Re: [OpenLayers] #3344: specialized layer for a grid of points

[OpenLayers]

#3344: specialized layer for a grid of points
--------------------------+-------------------------------------------------
 Reporter:  tschaub       |       Owner:  tschaub     
     Type:  feature       |      Status:  assigned    
 Priority:  minor         |   Milestone:  2.12 Release
Component:  Layer.Vector  |     Version:  2.10        
 Keywords:                |       State:  Commit      
--------------------------+-------------------------------------------------
Changes (by bartvde):

  * state:  Review => Commit


Comment:

 Very nice work Tim with great examples, a few questions/remarks wrt
 lib/OpenLayers/Layer/PointGrid.js, mostly wrt the docs:

  * why do we add fromBounds if we already have
 OpenLayers.Bounds.toGeometry? I personally don't see a need for both.
  * why is origin initialized to 0 and not to null? From the docs it's not
 entirely clear to me where the origin is located (bottom-left)?
  * maxFeatures and setMaxFeatures: is maxFeatures not an {Integer} always,
 so why use {Number} in docs?
  * make more explicit in docs that dx and dy are in map units and not in
 pixel units?
  * in getOrigin shouldn't we protect against getExtent returning null?
  * updateGrid misses docs for force
  * make it more explicit in the docs that rotation is negative in the
 clockwise direction

 Other than this it's good to go.

-- 
Ticket URL: <http://trac.openlayers.org/ticket/3344#comment:4>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer