[OpenLayers-Trac] Re: [OpenLayers] #3368: Make Protocol.WFS work with just featureType and featurePrefix

[OpenLayers]

#3368: Make Protocol.WFS work with just featureType and featurePrefix
--------------------------+-------------------------------------------------
 Reporter:  ahocevar      |       Owner:  tschaub     
     Type:  feature       |      Status:  new         
 Priority:  minor         |   Milestone:  2.12 Release
Component:  Protocol.WFS  |     Version:  2.11 RC1    
 Keywords:                |       State:  Commit      
--------------------------+-------------------------------------------------
Changes (by bartvde):

  * state:  Review => Commit


Comment:

 Looks good to go, relevant tests also pass in FF4, with a few
 remarks/questions:

  * A question about the change you made in
 lib/OpenLayers/Format/WFST/v1_0_0.js (and 1_1_0.js as well), are you 100%
 that in all cases both prefix and featureNS will be set? Imagine the
 probably hypothetical case where only prefix is set, we would get a
 prefixed node, but no xmlns declaration leading to invalid XML. Is it not
 safer to keep the current code or check for both prefix and featureNS?

  * Maybe add a comment to the change in
 lib/OpenLayers/Format/Filter/v1_0_0.js stating this will only happen if
 you configure geometryName with null, so it's not default behaviour to
 create invalid WFS 1.0 requests.

  * lib/OpenLayers/Protocol/WFS/v1.js: the comment about default prefix is
 this not implementation (i.e. GeoServer) specific? I don't think e.g.
 Mapserver has something equivalent to default namespace/workspace. Why not
 just state if the prefix matches the prefix of the geometry node's
 "featureNode"?

  * GML/Base talks about a default value of "geometry", but Protocol WFS
 mentions "the_geom". So isn't the default value geometry?

  * Put {{{var format = this.readFormat || this.format; }}} before the read
 call to simplify.

  * Trailing comma in tests/Format/WFST/v1_0_0.html and
 tests/Format/WFST/v1_1_0.html

  * tests/Format/Filter/v1_0_0.html: typo in test function name
 test_BBOX_noGeometrName

  * tests/Protocol/WFS.html: trailing comma

  * was the change in wfs:Delete made to pass the tests? So this mean we
 cannot write out a request anymore with: <ogc:PropertyName/> ? Or would
 this require setting geometryName to an empty string?

-- 
Ticket URL: <http://trac.openlayers.org/ticket/3368#comment:5>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer