[OpenLayers-Trac] Re: [OpenLayers] #3294: Panel: Allow deactivate tool controls by clicking the icon that represents them

OpenLayers trac-20090302 at openlayers.org
Mon May 9 17:11:13 EDT 2011


#3294: Panel: Allow deactivate tool controls by clicking the icon that represents
them
---------------------+------------------------------------------------------
 Reporter:  jorix    |       Owner:              
     Type:  feature  |      Status:  new         
 Priority:  minor    |   Milestone:  2.11 Release
Component:  general  |     Version:  2.10        
 Keywords:           |       State:  Review      
---------------------+------------------------------------------------------

Comment(by jorix):

 Replying to [comment:2 erilem]:
 > Review comments:
 >  * I'd rather have {{{allowDepress}}} default to false, to maintain the
 current behavior.
 ok

 >  * In the new doc text {{{TYPE_TOGGLE}}} should be {{{TYPE_TOOL}}}.
 oops!

 >  * I'd prefer a separate test function for {{{allowDepress}}} (I always
 prefer separate test functions)
 ok

 New patch attached.

-- 
Ticket URL: <http://trac.openlayers.org/ticket/3294#comment:3>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer


More information about the Trac mailing list