[OpenLayers-Trac] Re: [OpenLayers] #3495: GPX writer

[OpenLayers]

#3495: GPX writer
---------------------+------------------------------------------------------
 Reporter:  pgiraud  |       Owner:                 
     Type:  feature  |      Status:  new            
 Priority:  minor    |   Milestone:  2.12 Release   
Component:  general  |     Version:  2.11 RC3       
 Keywords:           |       State:  Needs More Work
---------------------+------------------------------------------------------
Changes (by marcjansen):

  * state:  Review => Needs More Work


Comment:

 Some short notes from a first look at the patch:

   * It seems as if you currently do not use the properties 'waypointsDesc'
 or 'tracksDesc'
   * there is no test for the second argument to write(), correct?
   * in appendAttributesNode(): shouldn't the 'name' fallback to feature.id
 instead of feature.attributes.id?
   * in appendAttributesNode(): There currently isn't a switch whether you
 are appending to a waypoint or a track, right? See first bullet.
   * in buildTrkSegNode(): Could you please move the variable declarations
 to the start of the function? This isn't a big issue, more of a
 preference.

-- 
Ticket URL: <http://trac.openlayers.org/ticket/3495#comment:1>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer