[OpenLayers-Trac] Re: [OpenLayers] #3495: GPX writer

[OpenLayers]

#3495: GPX writer
---------------------+------------------------------------------------------
 Reporter:  pgiraud  |       Owner:              
     Type:  feature  |      Status:  new         
 Priority:  minor    |   Milestone:  2.12 Release
Component:  general  |     Version:  2.11 RC3    
 Keywords:           |       State:  Review      
---------------------+------------------------------------------------------
Changes (by pgiraud):

  * state:  Needs More Work => Review


Comment:

 Replying to [comment:1 marcjansen]:

 Thanks a lot for this review.

 > Some short notes from a first look at the patch:
 >
 >   * It seems as if you currently do not use the properties
 'waypointsDesc' or 'tracksDesc'
 You're right. I forgot to replace those 2 properties by a unique
 'defaultDesc' one.

 >   * there is no test for the second argument to write(), correct?
 Yes, there is. See 'test_Format_GPX_serialize_metadata'.

 >   * in appendAttributesNode(): shouldn't the 'name' fallback to
 feature.id instead of feature.attributes.id?
 You're right. Let's be consistent. This is the way it's done in KML.
 Changed.

 >   * in appendAttributesNode(): There currently isn't a switch whether
 you are appending to a waypoint or a track, right? See first bullet.
 No, I don't want to distinguish both. This could be a futur enhancement.

 >   * in buildTrkSegNode(): Could you please move the variable
 declarations to the start of the function? This isn't a big issue, more of
 a preference.
 Done.

-- 
Ticket URL: <http://trac.openlayers.org/ticket/3495#comment:2>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer