[OpenLayers-Users] document.createElementNS on IE

Jeff Dege jdege at korterra.com
Tue Aug 14 15:14:37 EDT 2007


On Tuesday, August 14, 2007 at 1:39 PM Christopher Schmidt wrote:
> 
> On Tue, Aug 14, 2007 at 01:31:55PM -0500, Jeff Dege wrote:
> > I'm still seeing a lot of calls to document.createElementNS() in
> > /tschaub/feature.
> 
> Right you are. Copy paste failed me.
> http://svn.openlayers.org/sandbox/tschaub/xml/ and specficially:
> 
>
http://svn.openlayers.org/sandbox/tschaub/xml/lib/OpenLayers/Format/GML.
js
> 
> Which uses this.createElementNS.

So it does.  But it doesn't look ready for testing.

In Format/GML.js:

    createFeatureXML: function(feature) {
        var geometry = feature.geometry;
        var geometryNode = this.buildGeometryNode(geometry);
        var geometryNode;
        if(builder) {
            geometryNode = builder.apply(this, [geometry]);
        } else {
            OpenLayers.Console.error("Can't create GML for geometry
type: " +
                                     type);
        }

"builder" is an undeclared variable, geometryNode is declared twice, the
second throwing away the assignment of the first.

This doesn't look like it's been through even the most cursory unit
test.  In fact, it look like it's half-way through a restructuring.

But thanks for pointing me to it.  I might be able to make something of
it.





More information about the Users mailing list