[OWSLib-devel] Pull request: WFS 1.0.0 getfeature property handling Edit

[Miles, Brian]

Tom,

I added a test case in test/test_wfs_USDASSURGO.py.  Here is what the failure looks like without my proposed patch:

$ python -m unittest test_wfs_USDASSURGO
E
======================================================================
ERROR: runTest (test_wfs_USDASSURGO.USDASSURGOWFSTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_wfs_USDASSURGO.py", line 17, in runTest
    response = wfs.getfeature(typename=('MapunitPolyExtended',), filter=filter, propertyname=None)
  File "/usr/local/lib/python2.7/dist-packages/OWSLib-0.5.1-py2.7.egg/owslib/feature/wfs100.py", line 184, in getfeature
    request['propertyname'] = ','.join(propertyname)
TypeError

----------------------------------------------------------------------
Ran 1 test in 0.215s

FAILED (errors=1)


Let me know if you need anything else.

Thanks,

Brian Miles
PhD Candidate
Department of Geography
University of North Carolina at Chapel Hill

Saunders Hall
Campus Box 3220
Chapel Hill, NC 27599-3220




On Nov 27, 2012, at 9:56 PM, Tom Kralidis wrote:

Thanks for the reminder, I've since commented in the PR.

________________________________
From: brian_miles at unc.edu<mailto:brian_miles at unc.edu>
To: owslib-devel at lists.osgeo.org<mailto:owslib-devel at lists.osgeo.org>
Date: Wed, 28 Nov 2012 01:09:44 +0000
Subject: [OWSLib-devel] Pull request: WFS 1.0.0 getfeature property handling Edit


Hello,

Any chance of incorporating this pull request:

https://github.com/geopython/OWSLib/pull/37


Added check to getfeature(.) to allow for NoneType to be passed as the propertyname. This mirrors the behavior of wfs110.py and allows queries to USGS Soil Data Mart to succeed (http://SDMDataAccess.nrcs.usda.gov/Spatial/SDMNAD83UTM.wfs).

Not sure how this jibes with the 1.0.0 spec, but it makes calls to the above 1.0.0 WFS service work.

Thanks,

Brian

_______________________________________________ OWSLib-devel mailing list OWSLib-devel at lists.osgeo.org<mailto:OWSLib-devel at lists.osgeo.org>http://lists.osgeo.org/cgi-bin/mailman/listinfo/owslib-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/owslib-devel/attachments/20121128/e743e857/attachment.html>