[pdal-commits] [PDAL/PDAL] 7ebd16: Remove CMAKE_BUILD_WITH_INSTALL_RPATH=TRUE for OSX

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/PDAL/PDAL
  Commit: 7ebd16b3640bf404f3324f77825f20efd1e4227a
      https://github.com/PDAL/PDAL/commit/7ebd16b3640bf404f3324f77825f20efd1e4227a
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2015-01-30 (Fri, 30 Jan 2015)

  Changed paths:
    M CMakeLists.txt

  Log Message:
  -----------
  Remove CMAKE_BUILD_WITH_INSTALL_RPATH=TRUE for OSX

This option was breaking the out-of-the-box build on OSX, specifically
by breaking each test so it couldn't find libpdalcpp.dylib.

As far as I understand RPATH, CMAKE_BUILD_WITH_INSTALL_RPATH meant that
the libraries and executables in our build tree (un-installed) would
have their rpaths set to CMAKE_INSTALL_PREFIX directories. On a system
w/o an installed PDAL, this meant that each test executable had no
libpdalcpp.dylib to dynamically link against.

Removing this line falls back to the setting from above, where
CMAKE_BUILD_WITH_INSTALL_RPATH was set to FALSE (IMO the correct
setting).


  Commit: 4aeb0dcff181cf3d8845ec9e09fbe9022793498c
      https://github.com/PDAL/PDAL/commit/4aeb0dcff181cf3d8845ec9e09fbe9022793498c
  Author: Howard Butler <howard at hobu.co>
  Date:   2015-01-30 (Fri, 30 Jan 2015)

  Changed paths:
    M CMakeLists.txt

  Log Message:
  -----------
  Merge pull request #733 from gadomski/rpath-on-osx

Remove CMAKE_BUILD_WITH_INSTALL_RPATH=TRUE for OSX


Compare: https://github.com/PDAL/PDAL/compare/3ffa1ce7ff4c...4aeb0dcff181