[pdal-commits] [PDAL/PDAL] 67d851: On OSX, don't build with install rpath

GitHub noreply at github.com
Mon Apr 4 07:38:37 PDT 2016


  Branch: refs/heads/master
  Home:   https://github.com/PDAL/PDAL
  Commit: 67d8518c3cf6bddb1138d6cc7e0dcbb8049cf9de
      https://github.com/PDAL/PDAL/commit/67d8518c3cf6bddb1138d6cc7e0dcbb8049cf9de
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2016-04-01 (Fri, 01 Apr 2016)

  Changed paths:
    M CMakeLists.txt

  Log Message:
  -----------
  On OSX, don't build with install rpath

This is an identical change to #733. If cmake builds with install rpath
on OSX, `make test` is broken when `BUILD_SHARED_LIBS=ON` on OSX.


  Commit: 91d0d9aeab9f5b753c2fcbc7945c3ee954d3d0ec
      https://github.com/PDAL/PDAL/commit/91d0d9aeab9f5b753c2fcbc7945c3ee954d3d0ec
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2016-04-01 (Fri, 01 Apr 2016)

  Changed paths:
    M CMakeLists.txt

  Log Message:
  -----------
  Silence BUILD_SHARED_LIBS=ON gtest warnings

When `BUILD_SHARED_LIBS=ON`, gtest emits a couple of cmake warnings, one
about MACOSX_RPATH and one about a missing link_directory. We can quiet
both warnings by setting these properties.

We could also just change gtest's CMakeLists.txt in our vendor
directory, but I'm submitting this change on the principle that the
vendor subdirectories should stay pristine. If vendored software can be
tweaked in our tree, then we should discard this patch and instead fix
things in `vendor/gtest-1.7.0/CMakeLists.txt`.


  Commit: 8b5e2e69e467a90927f17280724fb6ff44e10922
      https://github.com/PDAL/PDAL/commit/8b5e2e69e467a90927f17280724fb6ff44e10922
  Author: Howard Butler <howard at hobu.co>
  Date:   2016-04-04 (Mon, 04 Apr 2016)

  Changed paths:
    M CMakeLists.txt

  Log Message:
  -----------
  Merge pull request #1210 from gadomski/gtest-shared-libs

Two changes when building on OSX w/ shared libs


Compare: https://github.com/PDAL/PDAL/compare/1df494299440...8b5e2e69e467


More information about the pdal-commits mailing list