[pdal-commits] [PDAL/PDAL] 51e0f7: Fix GDAL reader so that tests pass :)

Wed Feb 17 12:17:43 PST 2016

  Branch: refs/heads/windows-warnings-cleanup-hobu
  Home:   https://github.com/PDAL/PDAL
  Commit: 51e0f721c8cf672b9f3a2cf9553909269a8c84f5
      https://github.com/PDAL/PDAL/commit/51e0f721c8cf672b9f3a2cf9553909269a8c84f5
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M io/gdal/GDALReader.cpp
    M src/GDALUtils.cpp
    A test/data/gdal/byte.tif
    A test/data/gdal/data.xyz
    A test/data/gdal/float32.tif
    A test/data/gdal/float64.tif
    A test/data/gdal/int16.tif
    A test/data/gdal/int32.tif
    M test/unit/io/gdal/GDALReaderTest.cpp

  Log Message:
  -----------
  Fix GDAL reader so that tests pass :)
Test tif files from from GDAL autotest.  data.xyz file was generated from
float32.tif with gdal_translate.

  Commit: e41d193900cb1099d43b2f30d435e303f122cfd6
      https://github.com/PDAL/PDAL/commit/e41d193900cb1099d43b2f30d435e303f122cfd6
  Author: Mateusz Łoskot <mateusz at loskot.net>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M include/pdal/util/Utils.hpp

  Log Message:
  -----------
  Fix UB caused by incrementing pass-the-end iterator

Iterator returned from std::find_if may point pass-the-end,
but incrementing pass-the-end iterator is an undefined behaviour.

The bug was revealed by stringsplit case of the OptionsTest,
as well as UtilsTest, where final std::find_if returns end
iterator which must not be incremented.

  Commit: 931c8ae7eac69220248c6df4fd0d13618b55af47
      https://github.com/PDAL/PDAL/commit/931c8ae7eac69220248c6df4fd0d13618b55af47
  Author: Mateusz Łoskot <mateusz at loskot.net>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M src/util/Utils.cpp

  Log Message:
  -----------
  Fix out of range access bug in trimTrailing

If input string is empty, size()-1 overflows
causing character access beyond valid range.

  Commit: 37b3f35e75ef8fd52c66f789d6c1b35460a81bdf
      https://github.com/PDAL/PDAL/commit/37b3f35e75ef8fd52c66f789d6c1b35460a81bdf
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M include/pdal/util/Utils.hpp

  Log Message:
  -----------
  Merge pull request #1129 from mloskot/ml/fix-utils-split2-ub

Fix UB caused by incrementing pass-the-end iterator

  Commit: 2b1eb3f514fea3f0e20921fc57c4714cb0d1f48d
      https://github.com/PDAL/PDAL/commit/2b1eb3f514fea3f0e20921fc57c4714cb0d1f48d
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M src/util/Utils.cpp

  Log Message:
  -----------
  Merge pull request #1130 from mloskot/ml/fix-trim

Fix out of range access bug in trimTrailing

  Commit: bbb283471071564d1e71e25ef3dc1e94162c1bca
      https://github.com/PDAL/PDAL/commit/bbb283471071564d1e71e25ef3dc1e94162c1bca
  Author: Mateusz Łoskot <mateusz at loskot.net>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M test/unit/PDALUtilsTest.cpp

  Log Message:
  -----------
  Open output file in binary mode to avoid EOL translation.

Otherwise, on Windows, EOL is translated to CRLF and test
files do not compare as equal.

  Commit: d15222c41f95229cd40c3f9ca1486493cbf60d3c
      https://github.com/PDAL/PDAL/commit/d15222c41f95229cd40c3f9ca1486493cbf60d3c
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M test/unit/PDALUtilsTest.cpp

  Log Message:
  -----------
  Merge pull request #1132 from mloskot/ml/fix-cmp-files-eol

Open output file in binary mode to avoid EOL translation.

  Commit: 3c54b01b51763292418246bfda53827e4507b003
      https://github.com/PDAL/PDAL/commit/3c54b01b51763292418246bfda53827e4507b003
  Author: Mateusz Łoskot <mateusz at loskot.net>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M include/pdal/util/Uuid.hpp

  Log Message:
  -----------
  Fix too small sprintf buffer in Uuid::unparse

sprintf always appends terminating null character, so the character
buffer used with sprintf needs to accommodate it.

  Commit: 00a1ddf550b49429f7fc8c75837111dcd2ac753d
      https://github.com/PDAL/PDAL/commit/00a1ddf550b49429f7fc8c75837111dcd2ac753d
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M include/pdal/util/Uuid.hpp

  Log Message:
  -----------
  Merge pull request #1133 from mloskot/ml/fix-uuid-buffer-overrun

Fix too small sprintf buffer in Uuid::unparse

  Commit: 98505f1184200a236cc273db467d4b23db704330
      https://github.com/PDAL/PDAL/commit/98505f1184200a236cc273db467d4b23db704330
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M filters/crop/CropFilter.cpp
    M include/pdal/Polygon.hpp
    M src/Polygon.cpp

  Log Message:
  -----------
  Use standard error handling for stream failure of Polygon.
Remove unnecessary indirection for GEOS context.

  Commit: e76b229515a41b5cf7a2d891d0d5106042602659
      https://github.com/PDAL/PDAL/commit/e76b229515a41b5cf7a2d891d0d5106042602659
  Author: Howard Butler <howard at hobu.co>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M filters/crop/CropFilter.cpp
    M include/pdal/Polygon.hpp
    M src/Polygon.cpp

  Log Message:
  -----------
  Merge pull request #1134 from PDAL/polycontext

Use standard error handling for stream failure of Polygon.

  Commit: e933b45d4510d1779219d0bc3441113a51d7b27c
      https://github.com/PDAL/PDAL/commit/e933b45d4510d1779219d0bc3441113a51d7b27c
  Author: Howard Butler <howard at hobu.co>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M io/gdal/GDALReader.cpp
    M src/GDALUtils.cpp
    A test/data/gdal/byte.tif
    A test/data/gdal/data.xyz
    A test/data/gdal/float32.tif
    A test/data/gdal/float64.tif
    A test/data/gdal/int16.tif
    A test/data/gdal/int32.tif
    M test/unit/io/gdal/GDALReaderTest.cpp

  Log Message:
  -----------
  Merge pull request #1135 from PDAL/fixgdal

Fix GDAL reader so that tests pass

  Commit: 04072b6ec918a192b0729d20ebeb58207729aef2
      https://github.com/PDAL/PDAL/commit/04072b6ec918a192b0729d20ebeb58207729aef2
  Author: Howard Butler <howard at hobu.co>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M filters/crop/CropFilter.cpp
    M include/pdal/Polygon.hpp
    M include/pdal/util/Utils.hpp
    M include/pdal/util/Uuid.hpp
    M io/gdal/GDALReader.cpp
    M src/GDALUtils.cpp
    M src/Polygon.cpp
    M src/util/Utils.cpp
    A test/data/gdal/byte.tif
    A test/data/gdal/data.xyz
    A test/data/gdal/float32.tif
    A test/data/gdal/float64.tif
    A test/data/gdal/int16.tif
    A test/data/gdal/int32.tif
    M test/unit/PDALUtilsTest.cpp
    M test/unit/io/gdal/GDALReaderTest.cpp

  Log Message:
  -----------
  Merge remote-tracking branch 'origin/master' into windows-warnings-cleanup-hobu

Compare: https://github.com/PDAL/PDAL/compare/f06f3b22315b...04072b6ec918