[pdal-commits] [PDAL/PDAL] 9d0c9a: Improve quality of derivative writer outputs
GitHub
noreply at github.com
Fri Feb 10 10:12:27 PST 2017
Branch: refs/heads/master
Home: https://github.com/PDAL/PDAL
Commit: 9d0c9ad90019dee615ff2d70b3029c27fb60bb3a
https://github.com/PDAL/PDAL/commit/9d0c9ad90019dee615ff2d70b3029c27fb60bb3a
Author: Bradley J Chambers <brad.chambers at gmail.com>
Date: 2017-02-03 (Fri, 03 Feb 2017)
Changed paths:
M io/DerivativeWriter.cpp
M io/DerivativeWriter.hpp
M pdal/EigenUtils.cpp
M pdal/EigenUtils.hpp
M test/unit/EigenTest.cpp
Log Message:
-----------
Improve quality of derivative writer outputs
First, we had a bug in how we computed slope for the D8 method. We were
dividing the slope in the cardinal directions by sqrt(2) instead of the
diagonals.
Second, we offer a switch to output slopes in degrees, not just percent. Note,
this is really just a convenience as analysts should have been able to convert
in the GIS tool of their choice.
Finally, our DSM generation approach had a tendency to leave voids in the max
elevation matrix. We switched to something very similar to what the GDAL writer
does, that is, specifying a radius and considering all points within the
cylinder centered at the current grid cell. At the same time, we remove the DSM
cleaning step.
Future work should consider unifying the behavior of GDALGrid/GDALWriter with
DerivativeWriter such that we can leverage the existing implementation and hole
filling capabilities. We may also be able to convert this to support streaming.
Commit: 38553e3b6a7d57c0087584eac075b577725cbc80
https://github.com/PDAL/PDAL/commit/38553e3b6a7d57c0087584eac075b577725cbc80
Author: Bradley J Chambers <brad.chambers at gmail.com>
Date: 2017-02-03 (Fri, 03 Feb 2017)
Changed paths:
M io/DerivativeWriter.cpp
M io/DerivativeWriter.hpp
Log Message:
-----------
Minor refactoring of the conversion between percent slope and degrees
Commit: c7cef916aca1ab9d6f01ce67b88a66fb2be43788
https://github.com/PDAL/PDAL/commit/c7cef916aca1ab9d6f01ce67b88a66fb2be43788
Author: chambbj <brad.chambers at gmail.com>
Date: 2017-02-10 (Fri, 10 Feb 2017)
Changed paths:
M io/DerivativeWriter.cpp
M io/DerivativeWriter.hpp
M pdal/EigenUtils.cpp
M pdal/EigenUtils.hpp
M test/unit/EigenTest.cpp
Log Message:
-----------
Merge pull request #1488 from PDAL/slope-update
Improve quality of derivative writer outputs
Compare: https://github.com/PDAL/PDAL/compare/9ca444adefa3...c7cef916aca1
More information about the pdal-commits
mailing list