[pdal-commits] [PDAL/PDAL] 23fc93: Fix path separator lookup in Unicode paths on Wind...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/PDAL/PDAL
  Commit: 23fc93fc0bdc7a548ea087280382a1df58d49e81
      https://github.com/PDAL/PDAL/commit/23fc93fc0bdc7a548ea087280382a1df58d49e81
  Author: Mateusz Loskot <mateusz at loskot.net>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M pdal/util/FileUtils.cpp
    R test/data/japanese.txt
    A test/data/unicode/japanese-pr2135.txt
    A test/data/unicode/japanese-pr2227.txt
    M test/unit/FileUtilsTest.cpp

  Log Message:
  -----------
  Fix path separator lookup in Unicode paths on Windows (#2227)

Apparently, searching UTF8-encoded string with std::string::find* routines
may fail to return correct position for some character sets. Thus, search
for path separator in UTF-16 string.

Update directory operations to convert path name to std::wstring on Windows.
Update related test case in FileUtilsTest.cpp.

Follows up PR #2135 and refines PR #2160.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.