[pdal-commits] [PDAL/PDAL] 23fc93: Fix path separator lookup in Unicode paths on Wind...

GitHub noreply at github.com
Wed Oct 24 08:49:04 PDT 2018


  Branch: refs/heads/conda-windows-tests
  Home:   https://github.com/PDAL/PDAL
  Commit: 23fc93fc0bdc7a548ea087280382a1df58d49e81
      https://github.com/PDAL/PDAL/commit/23fc93fc0bdc7a548ea087280382a1df58d49e81
  Author: Mateusz Loskot <mateusz at loskot.net>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M pdal/util/FileUtils.cpp
    R test/data/japanese.txt
    A test/data/unicode/japanese-pr2135.txt
    A test/data/unicode/japanese-pr2227.txt
    M test/unit/FileUtilsTest.cpp

  Log Message:
  -----------
  Fix path separator lookup in Unicode paths on Windows (#2227)

Apparently, searching UTF8-encoded string with std::string::find* routines
may fail to return correct position for some character sets. Thus, search
for path separator in UTF-16 string.

Update directory operations to convert path name to std::wstring on Windows.
Update related test case in FileUtilsTest.cpp.

Follows up PR #2135 and refines PR #2160.


  Commit: c027892137e3ad457fbcbd8158578e34d2ac13b7
      https://github.com/PDAL/PDAL/commit/c027892137e3ad457fbcbd8158578e34d2ac13b7
  Author: Howard Butler <howard at hobu.co>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M pdal/util/FileUtils.cpp
    R test/data/japanese.txt
    A test/data/unicode/japanese-pr2135.txt
    A test/data/unicode/japanese-pr2227.txt
    M test/unit/FileUtilsTest.cpp

  Log Message:
  -----------
  Merge remote-tracking branch 'origin/master' into conda-windows-tests


  Commit: c67b626b51d7f43c723fbec15311d72a46c6844c
      https://github.com/PDAL/PDAL/commit/c67b626b51d7f43c723fbec15311d72a46c6844c
  Author: Howard Butler <howard at hobu.co>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M scripts/appveyor/build.cmd
    M scripts/appveyor/config.cmd
    M scripts/appveyor/install.cmd

  Log Message:
  -----------
  try ninja


Compare: https://github.com/PDAL/PDAL/compare/9b98eab35ba2...c67b626b51d7
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the pdal-commits mailing list