[pdal-commits] [PDAL/PDAL] c6abbe: Minor updates to several filters (#3270)

[chambbj]

  Branch: refs/heads/master
  Home:   https://github.com/PDAL/PDAL
  Commit: c6abbef2aefa3d73862a227e323d58dbfd98392a
      https://github.com/PDAL/PDAL/commit/c6abbef2aefa3d73862a227e323d58dbfd98392a
  Author: chambbj <brad.chambers at gmail.com>
  Date:   2020-11-30 (Mon, 30 Nov 2020)

  Changed paths:
    M doc/stages/filters.litree.rst
    M doc/stages/filters.lof.rst
    M filters/ApproximateCoplanarFilter.cpp
    M filters/ApproximateCoplanarFilter.hpp
    M filters/EigenvaluesFilter.cpp
    M filters/EigenvaluesFilter.hpp
    M filters/EstimateRankFilter.cpp
    M filters/EstimateRankFilter.hpp
    M filters/LOFFilter.cpp
    M filters/LOFFilter.hpp
    M filters/LiTreeFilter.cpp
    M filters/LiTreeFilter.hpp
    M filters/MiniballFilter.cpp
    M filters/MiniballFilter.hpp
    M filters/OptimalNeighborhoodFilter.cpp
    M filters/OptimalNeighborhoodFilter.hpp
    M filters/PlaneFitFilter.cpp
    M filters/PlaneFitFilter.hpp
    M filters/RadialDensityFilter.cpp
    M filters/RadialDensityFilter.hpp
    M filters/ReciprocityFilter.cpp
    M filters/ReciprocityFilter.hpp
    M pdal/Dimension.json

  Log Message:
  -----------
  Minor updates to several filters (#3270)

* Minor updates to several filters

Initial focus is on updating static filters to always register official
Dimensions.

* LiTreeFilter now registers existing ClusterID instead of custom
  TreeID.

* LOFFilter now registers existing NNDistance instead of custom
  KDistance.

* OptimalNeighborhoodFilter now registers existing OptimalRadius and
  OptimalKNN.

* Register the following as "official" Dimensions: Coplanar,
  Eigenvalue0, Eigenvalue1, Eigenvalue2, LocalOutlierFactor,
  LocalReachabilityDistance, Miniball, PlaneFit, RadialDensity, Rank,
  Reciprocity

While updating Dimensions, also took the opportunity to:

* Be more explicit about datatypes, instead of relying on auto, to
  improve readability.

* Use PointView range-based for loops where it make sense. Generally
  makes code a little more succinct.

* Do not pass KDIndex as frequently, when it can typically be grabbed
  off the view at no cost.

* Addressing PR comments