[pdal] first build notes: boost namespace, missing include, laszip include guards

[Howard Butler]

On Aug 8, 2011, at 11:52 AM, Bradley Chambers wrote:

> I'm stepping through building PDAL for the first time this morning (MSVC 2005).

PDAL is regularly built on MSVC 2010 and OS X gcc 4.2.1.  All other compiler/OS combinations are buy beware :)


> 
> I've noted a number of updates recently to make better use of the
> boost:: namespace when defining uint8_t, uint16_t, etc. These changes
> do not appear to have made it to
> src/drivers/las/VariableLengthRecord.cpp quite yet. Along the same
> lines, it's probably not a bad idea to specifically add #include
> <boost/cstdint.hpp> in any of the files where these types are being
> used (although I think in many cases it is being included through
> other header files).
> 
> I also found that I needed to add #include <pdal/exceptions.hpp> to
> src/drivers/las/LasHeaderWriter.cpp.
> 
> If laszip is optional, would everyone agree that all associated
> includes should be guarded with PDAL_HAVE_LASZIP? I've found
> references in the following files:
> - src/drivers/las/Iterator.cpp
> - src/drivers/las/Reader.cpp

Yes, it is the intent that LASzip is optional.  

Coordinate on IRC with me, and I'll get you push access so you can participate and clean up these issues as you go.