[pdal] first build notes: boost namespace, missing include, laszip include guards

[Michael P. Gerlek]

My two cents-

* Yes, I build with VS2010 all the time, against boost 1.46.1.  What
compiler are you using?

* I added a pdal.h some time ago, with the intent that it be used to hold
all the #includes of "core" stuff -- in theory, all the pdal .h files should
first include pdal.h.  So adding cstdint.h in there might be the best way to
go.  Maybe pdal_exceptions.h too.

* If you look at pdal_defines.h, you'll see a block labeled "availability of
3rd-party libraries": in theory, we should be able to build any combo of
those #defines.  LASZIP and GDAL and ORACLE are the main ones, though.
Someday we'll have a buildbot to harden this stuff.

Welcome to the club!

-mpg


-----Original Message-----
From: pdal-bounces at lists.osgeo.org [mailto:pdal-bounces at lists.osgeo.org] On
Behalf Of Howard Butler
Sent: Tuesday, August 09, 2011 7:34 AM
To: pdal at lists.osgeo.org
Subject: Re: [pdal] first build notes: boost namespace, missing include,
laszip include guards


On Aug 8, 2011, at 11:52 AM, Bradley Chambers wrote:

> I'm stepping through building PDAL for the first time this morning (MSVC
2005).

PDAL is regularly built on MSVC 2010 and OS X gcc 4.2.1.  All other
compiler/OS combinations are buy beware :)


> 
> I've noted a number of updates recently to make better use of the
> boost:: namespace when defining uint8_t, uint16_t, etc. These changes
> do not appear to have made it to
> src/drivers/las/VariableLengthRecord.cpp quite yet. Along the same
> lines, it's probably not a bad idea to specifically add #include
> <boost/cstdint.hpp> in any of the files where these types are being
> used (although I think in many cases it is being included through
> other header files).
> 
> I also found that I needed to add #include <pdal/exceptions.hpp> to
> src/drivers/las/LasHeaderWriter.cpp.
> 
> If laszip is optional, would everyone agree that all associated
> includes should be guarded with PDAL_HAVE_LASZIP? I've found
> references in the following files:
> - src/drivers/las/Iterator.cpp
> - src/drivers/las/Reader.cpp

Yes, it is the intent that LASzip is optional.  

Coordinate on IRC with me, and I'll get you push access so you can
participate and clean up these issues as you go.

_______________________________________________
pdal mailing list
pdal at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/pdal