[pdal] Compile error with master

[Stefan Ziegler]

Hi

can anybody give a hint a about "nitro". I get some cmake errors:


On Wed, Apr 20, 2016 at 6:32 AM, Stefan Ziegler <stefan.ziegler.de at gmail.com
> wrote:

> Similar mistake again:
>
> [ 39%] Built target pdal_plugin_filter_statisticaloutlier
> [ 39%] Built target pdal_plugin_filter_voxelgrid
> [ 39%] Building CXX object
> plugins/pcl/CMakeFiles/pdal_plugin_kernel_view.dir/kernel/ViewKernel.cpp.o
> /home/stefan/sources/pdal/plugins/pcl/kernel/ViewKernel.cpp: In member
> function ‘virtual int pdal::ViewKernel::execute()’:
> /home/stefan/sources/pdal/plugins/pcl/kernel/ViewKernel.cpp:137:35: error:
> ‘setCommonOptions’ was not declared in this scope
>      setCommonOptions(readerOptions);
>                                    ^
> make[2]: ***
> [plugins/pcl/CMakeFiles/pdal_plugin_kernel_view.dir/kernel/ViewKernel.cpp.o]
> Error 1
> make[1]: *** [plugins/pcl/CMakeFiles/pdal_plugin_kernel_view.dir/all]
> Error 2
> make: *** [all] Error 2
> stefan at inflexible:~/sources/pdal/build$
>
> regards
> Stefan
>
> On Fri, Apr 15, 2016 at 4:58 PM, Andrew Bell <andrew.bell.ia at gmail.com>
> wrote:
>
>>
>> On Fri, Apr 15, 2016 at 1:23 AM, Mateusz Loskot <mateusz at loskot.net>
>> wrote:
>>
>>> On 15 April 2016 at 08:11, Stefan Ziegler <stefan.ziegler.de at gmail.com>
>>> wrote:
>>> >
>>> > /home/stefan/sources/pdal/plugins/pcl/kernel/ViewKernel.cpp:139:54:
>>> note:
>>> > candidate is:
>>> > In file included from
>>> > /home/stefan/sources/pdal/plugins/pcl/kernel/ViewKernel.hpp:38:0,
>>> >                  from
>>> > /home/stefan/sources/pdal/plugins/pcl/kernel/ViewKernel.cpp:35:
>>> > /home/stefan/sources/pdal/include/pdal/Kernel.hpp:81:12: note:
>>> pdal::Stage&
>>> > pdal::Kernel::makeReader(const string&, std::string)
>>> >      Stage& makeReader(const std::string& inputFile, std::string
>>> driver);
>>> >             ^
>>> > /home/stefan/sources/pdal/include/pdal/Kernel.hpp:81:12: note:
>>>  candidate
>>> > expects 2 arguments, 1 provided
>>> > make[2]: ***
>>> >
>>> [plugins/pcl/CMakeFiles/pdal_plugin_kernel_view.dir/kernel/ViewKernel.cpp.o]
>>> > Error 1
>>> > make[1]: *** [plugins/pcl/CMakeFiles/pdal_plugin_kernel_view.dir/all]
>>> Error
>>> > 2
>>> > make: *** [all] Error 2
>>>
>>> It looks like PCL plugin is missing update related to this change
>>>
>>> https://github.com/PDAL/PDAL/commit/2b2eeba95906f5a96fab88d88fb0a0fae59397df
>>>
>>> Perhaps it will be enough to patch the
>>> pdal/plugins/pcl/kernel/ViewKernel.cpp:139
>>>
>>> Stage& readerStage(Kernel::makeReader(m_inputFile));
>>>
>>> to read
>>>
>>> Stage& readerStage(Kernel::makeReader("kernels.view", m_inputFile));
>>>
>>
>> Brad told me nobody was using the PCL viewer.  I guess that's incorrect :)
>>
>> The change should be to:
>>
>> Stage& readerStage(Kernel::makeReader("m_inputFile, ""));
>>
>> I'll make the change in master.
>>
>> --
>> Andrew Bell
>> andrew.bell.ia at gmail.com
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/pdal/attachments/20160429/20515b34/attachment.html>