[postgis-devel] ICONV autodetection (head branch)

[strk at refractions.net]

On Mon, Jul 04, 2005 at 03:30:17PM +0200, Jean David TECHER wrote:
> No prob Sandro...I've already sent U my mail last week! Strange?
> 
> My patch is attached to this mail for win32

Ok. Correct me if I'm wrong.
First patch is USE_ICONV=0 forced, which shouldn't be needed anymore.
Second patch is against Makefile.shlib, which should have been
copied from postgresql sourced.

Alex, can you take a look at the latter ?

--strk;

> 
> 
> ---------------------------------------------------------------
> TECHER Jean David
> 01MAP
> e-mail: david at 01map.net
> Tél: 04 67 45 60 27
> Entreprise: http://www.01map.net
> Perso: http://techer.pascal.free.fr/postgis/
> ---------------------------------------------------------------
>   ----- Original Message ----- 
>   From: strk at refractions.net 
>   To: PostGIS Development Discussion 
>   Sent: Monday, July 04, 2005 3:13 PM
>   Subject: Re: [postgis-devel] ICONV autodetection (head branch)
> 
> 
>   Sorry Dave, I'm a bit slow.
>   Can we try to discuss one thing at time ?
>   Which patch did you apply ? Didn't postgis compile w/out patches ?
>   --strk;
> 
>   On Mon, Jul 04, 2005 at 02:04:25PM +0200, Jean David TECHER wrote:
>   > Yes Master!!! :-)
>   > 
>   > cvs checkout postgis
>   > 
>   > I applied my patch for windows
>   > and let in postgis/Makefile.config.in
>   > 
>   > USE_ICONV=@USE_ICONV@
>   > 
>   > I got
>   > 
>   > for configure
>   > 
>   >  
>   >  SUMMARY
>   >  -------------------------------------------------------
>   >  
>   >  HOST_OS: mingw32
>   >  
>   >    PGSQL: /c/PostgreSQL/8.0.3/bin/pg_config
>   >     GEOS: /c/PostgreSQL/8.0.3/bin/geos-config
>   >     PROJ: dir=/c/PostgreSQL/8.0.3/bin/..
>   >    ICONV: 0
>   >   
>   >  PORTNAME: win32
>   >    PREFIX: /usr/local
>   >   EPREFIX: ${prefix}
>   >       DOC: ${prefix}/share/doc
>   >      DATA: ${prefix}/share/postgresql/contrib
>   >       MAN: ${prefix}/man
>   >       BIN: c:/PostgreSQL/8.0.3/bin
>   >       EXT: c:/PostgreSQL/8.0.3/lib (\$$libdir)
>   >  -------------------------------------------------------
>   >  
>   > Hum....!!! The only problem is to be able to have lwpostgis.sql and spatial_ref_sys.sql in the same directory og PG SHAREDIR
>   > 
>   > Not really a goog idea!!! It's better to let postgis-prefix=/usr/local by default
>   > 
>   > I will copy *.sql done by postgis manually (*.sql + doc + man)
>   > 
>   > ok thanks :-)
>   > 
>   > However Sandro I think it will be a great idea to let for win32 Path_to_PosttGIS_library = $lidbir even if user give '--prefix=...' when he uses configure
>   > 
>   > I mean for win32 it's better to have 
>   > 
>   > EXT     = (\$$libdir)
>   > 
>   > instead of 
>   > 
>   > EXT   :=   ${exec_prefix}/$/libexec when we use configure
>   > 
>   > So I will not have to replace EXT by libdir in lwpostgis.sql since PostgreSLQ doesn't support /c/ in path
>   > ---------------------------------------------------------------
>   > TECHER Jean David
>   > 01MAP
>   > e-mail: david at 01map.net
>   > Tél: 04 67 45 60 27
>   > Entreprise: http://www.01map.net
>   > Perso: http://techer.pascal.free.fr/postgis/
>   > ---------------------------------------------------------------
>   >   ----- Original Message ----- 
>   >   From: strk at refractions.net 
>   >   To: PostGIS Development Discussion 
>   >   Sent: Monday, July 04, 2005 11:48 AM
>   >   Subject: [postgis-devel] ICONV autodetection (head branch)
>   > 
>   > 
>   >   On Thu, Jun 30, 2005 at 10:36:11AM +0200, Jean David TECHER wrote:
>   >   ...
>   >   > Sorry for iconv I've had problem so I put USE_ICONV=0 in postgis/Makefile.config.in
>   >   > 
>   >   > Make and make install works fine!!!
>   > 
>   >   I've reworked iconv detection code to be more conservative.
>   >   It should now be enabled only if the c library provide that functionality.
>   >   (no external libiconv supported).
>   > 
>   >   This should remove the need of manually edit Makefile.config
>   > 
>   >   --strk;
>   >   _______________________________________________
>   >   postgis-devel mailing list
>   >   postgis-devel at postgis.refractions.net
>   >   http://postgis.refractions.net/mailman/listinfo/postgis-devel
> 
>   > _______________________________________________
>   > postgis-devel mailing list
>   > postgis-devel at postgis.refractions.net
>   > http://postgis.refractions.net/mailman/listinfo/postgis-devel
> 
>   _______________________________________________
>   postgis-devel mailing list
>   postgis-devel at postgis.refractions.net
>   http://postgis.refractions.net/mailman/listinfo/postgis-devel

> _______________________________________________
> postgis-devel mailing list
> postgis-devel at postgis.refractions.net
> http://postgis.refractions.net/mailman/listinfo/postgis-devel