[postgis-devel] Do I need to worry about these warnings

[Mark Cave-Ayland]

Obe, Regina wrote:
> Finally decided to give the new 1.3.4SVN a test drive.  It compiles.
> Haven't tried using it yet though, but I get the below warnings during
> compile.  Do I need to worry about these?
> 
> lwgeom_geos_c.c
> lwgeom_geos_c.c: In function 'GEOS2LWGEOM':
> lwgeom_geos_c.c:2942: warning: assignment discards qualifiers from
> pointer target type
> lwgeom_geos_c.c:2951: warning: assignment discards qualifiers from
> pointer target type
> lwgeom_geos_c.c:2961: warning: assignment discards qualifiers from
> pointer target type
> lwgeom_geos_c.c:2962: warning: assignment discards qualifiers from
> pointer target type
> lwgeom_geos_c.c:2966: warning: assignment discards qualifiers from
> pointer target type
> lwgeom_geos_c.c:2967: warning: assignment discards qualifiers from
> pointer target type
> lwgeom_geos_c.c:2988: warning: assignment discards qualifiers from
> pointer target type
> lwgeom_geos_c.c: In function 'polygonize_garray':
> lwgeom_geos_c.c:3352: warning: passing argument 1 of 'GEOSPolygonize'
> from incompatible pointer type
> lwgeom_geos_c.c: In function 'LWGEOM_buildarea':
> lwgeom_geos_c.c:3502: warning: passing argument 1 of 'GEOSPolygonize'
> from incompatible pointer type
> lwgeom_geos_c.c:3545: warning: assignment discards qualifiers from
> pointer target type
> 
> I'm running the below on openSUSE 10.3
> "POSTGIS="1.3.4SVN" GEOS="3.0.0-CAPI-1.4.1" PROJ="Rel. 4.6.0, 21 Dec
> 2007" USE_STATS"
> 
> I can't remember if I got this error before.  I don't think I was paying
> too much attention if it compiled.

Yeah, these errors have always been there. I'm fairly sure it's to do 
with changing the GEOS API to work correctly on 64-bit architectures, 
however to change them to the correct types would break using GEOS < 
3.0. Maybe we should consider having GEOS 3.0.0 the minimum version for 
1.4 which means we should be able to eliminate them - or is that too 
gutsy a call?


ATB,

Mark.

-- 
Mark Cave-Ayland
Sirius Corporation - The Open Source Experts
http://www.siriusit.co.uk
T: +44 870 608 0063