[postgis-devel] RE: [postgis-commits] svn - r3187 - trunk/doc

[Kevin Neufeld]

I could, but it hasn't been thoroughly tested.  I mean, I use it often, 
and it works well, but I just found a bug last night in the script when 
probing for srids of -1 (I don't normally deal with -1 srids, so it was 
kinda fluky I found it).  In this light, I think it could wait a bit 
before getting into the branch - perhaps after 1.3.4 has been release. 
More testing would be appreciated.

Yes, good call about the availability notes.

Cheers,
Kevin

Obe, Regina wrote:
> Kevin,
> Any plans to commit this to 1.3 branch.  I guess its nearing close to
> release, but I don't personally see a problem with doing so if the
> higher ups (Mark and Paul) don't and would make my life easier, since
> now if I update the postgis_comments.sql for 1.3.4, I have to strip this
> function out since I generate it from the 1.4 docs.
> 
> Anyrate you should put in an Availability notice in the docs and
> lwpostgis.sql.in.c since its a new function.
> 
> Thanks,
> Regina  
> 
> -----Original Message-----
> From: postgis-commits-bounces at postgis.refractions.net
> [mailto:postgis-commits-bounces at postgis.refractions.net] On Behalf Of
> postgis-commits at postgis.refractions.net
> Sent: Monday, October 27, 2008 2:30 AM
> To: postgis-commits at postgis.refractions.net
> Subject: [postgis-commits] svn - r3187 - trunk/doc
> 
> Author: kneufeld
> Date: 2008-10-26 23:29:42 -0700 (Sun, 26 Oct 2008)
> New Revision: 3187
> 
> Modified:
>    trunk/doc/reference_new.xml
> Log:
> updated description for Populate_Geometry_Columns
> 
> Modified: trunk/doc/reference_new.xml
> ===================================================================
> --- trunk/doc/reference_new.xml	2008-10-27 06:13:35 UTC (rev 3186)
> +++ trunk/doc/reference_new.xml	2008-10-27 06:29:42 UTC (rev 3187)
> @@ -820,11 +820,10 @@
>          <title>Description</title>
>      
>          <para>Ensures geometry columns have appropriate spatial
> constraints and
> -        exist in the <varname>geometry_columns</varname> table.</para>
> +        exist in the <varname>geometry_columns</varname> table.  In
> particular, 
> +        this means that every geometry column belonging to a table has
> at least 
> +        three constraints:</para>
>      
> -        <para>In particular, this means that every geometry column
> belonging to a
> -        table has at least three constraints:</para>
> -    
>          <itemizedlist>
>            <listitem>
>              <para><varname>enforce_dims_the_geom</varname> - ensures
> every
> @@ -845,21 +844,27 @@
>            </listitem>
>          </itemizedlist>
>      
> -        <para>If a table oid is provided, this function tries to
> determine the
> -        srid, dimension, and geometry type of all geometry columns in
> the table,
> -        adding contraints as necessary. If successful, an appropriate
> row is
> -        inserted into the geometry_column table, otherwise, the
> exception is
> -        caught and an error notice is raised describing the
> problem.</para>
> +        <para>If a table <varname>oid</varname> is provided, this
> function 
> +        tries to determine the srid, dimension, and geometry type of
> all 
> +        geometry columns in the table, adding contraints as necessary.
> if 
> +        successful, an appropriate row is inserted into the
> geometry_column 
> +        table, otherwise, the exception is caught and an error notice
> is raised 
> +        describing the problem.</para>
>      
> -        <para>If an oid of a view is provided, as with a table oid,
> this function
> -        tries to determine the srid, dimension, and type of all the
> geometries in
> -        the view, inserting appropriate entries into the
> geometry_columns table,
> -        but nothing is done to enforce contraints.</para>
> +        <para>If the <varname>oid</varname> of a view is provided, as
> with a 
> +        table oid, this function tries to determine the srid,
> dimension, and 
> +        type of all the geometries in the view, inserting appropriate
> entries 
> +        into the <varname>geometry_columns</varname> table, but nothing
> is done 
> +        to enforce contraints.</para>
>      
>          <para>The parameterless variant is a simple wrapper for the
> parameterized
>          variant that first truncates and repopulates the
> geometry_columns table
>          for every spatial table and view in the database, adding
> spatial
> -        contraints to tables where appropriate.</para>
> +        contraints to tables where appropriate.  It returns a summary
> of the 
> +        number of geometry columns detected in the database and the
> number that
> +        were inserted into the <varname>geometry_columns</varname>
> table.  The
> +        parameterized version simply returns the number of rows
> inserted into 
> +        the <varname>geometry_columns</varname> table.</para>
>        </refsection>
>      
>        <refsection>
> 
> _______________________________________________
> postgis-commits mailing list
> postgis-commits at postgis.refractions.net
> http://lists.refractions.net/mailman/listinfo/postgis-commits
> -----------------------------------------
> The substance of this message, including any attachments, may be
> confidential, legally privileged and/or exempt from disclosure
> pursuant to Massachusetts law. It is intended
> solely for the addressee. If you received this in error, please
> contact the sender and delete the material from any computer.
> _______________________________________________
> postgis-devel mailing list
> postgis-devel at postgis.refractions.net
> http://postgis.refractions.net/mailman/listinfo/postgis-devel