[postgis-devel] Issue 110 in postgis: shp2pgsql new option to not batch commit

[codesite-noreply at google.com]

Comment #1 on issue 110 by mark.cav... at siriusit.co.uk: shp2pgsql new option  
to not batch commit
http://code.google.com/p/postgis/issues/detail?id=110

Two things here:

i) Inserting transactions throughout a large dataset is, IMHO, wrong. You  
either want
the whole set of data inserted atomically, or you handle the consequences  
yourself.
So I would suggest removing all of the code related to batching in  
LoadData() and
just have one single BEGIN...COMMIT block. At least then if the insert  
fails, you can
manually remove the BEGIN/COMMIT yourself and live with what gets inserted.

ii) The 1.4 version of loader currently throws an error if an invalid  
geometry is
inserted; it would be fairly easy to modify this so that the erroneus  
geometry were
simply omitted.


ATB,

Mark.


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings