[postgis-devel] Making postgis_comments.sql

[Obe, Regina]

Actually that was why I didn't want it in there.

Because I don't want it part of the transaction.  The problem is
that I'm not distinquishing between GEOS versions so the comments
include functions such as ST_IsValidReason that are not present if you are not running GEOS 3.1.

If its part of the transaction, I think it would fail and everything would be rolled back

So if it were to be included, it would need to be added after the commit so the errors
could be ignored.



-----Original Message-----
From: postgis-devel-bounces at postgis.refractions.net on behalf of Kevin Neufeld
Sent: Mon 2/23/2009 12:48 PM
To: PostGIS Development Discussion
Subject: Re: [postgis-devel] Making postgis_comments.sql
 
Ok, great.  Good job by the way with the comments file.

In a way, it would be nice if the file was concatenated to the main ./postgis/postgis.sql file.  The COMMIT statement 
would obviously have to be dealt with and moved to the end of the concentation.

It's nice not having the dependency between the actual project and the documentation builds.  Maybe we could add a new 
target in the ./doc/Makefile.in ... something like 'merge-sql' that will concatenate the the sql files together if the 
main project has been built.  That would still allow either to be built by themselves, but the main tarball would still 
have just the two sql files: postgis.sql and spatial_ref_sys.sql.

The reason I suggest this is that down the road I see us adding more sql files to the list, like function_costs.sql.  It 
would be nice to try to keep the number of files people have to load at a minimum.

What do you think?
-- Kevin

Obe, Regina wrote:
> Kevin,
> 
> Thanks -  that will do.  I just cared about it being in the downloadable 
> file and don't care too much about how it gets there.
> 
> 
> 
> -----Original Message-----
> From: postgis-devel-bounces at postgis.refractions.net on behalf of Kevin 
> Neufeld
> Sent: Mon 2/23/2009 12:05 PM
> To: PostGIS Development Discussion
> Subject: Re: [postgis-devel] Making postgis_comments.sql
> 
> I purposely setup Hudson so it *doesn't* use the all target.  The 'all' 
> target is set to build the single html file
> 'html/postgis.html'.  I didn't think we wanted that ... rather, I'm 
> specifically calling 'make chunked-html' (builds the
> multiple html files we currently have for the docs website) and then 
> 'make pdf'.
> 
> I just added your target of 'make ../postgis_comments.sql' to the Hudson 
> build list.  You should now find your sql file
> the svn tarball.
> 
> Do you still want it to make 'all'?
> 
> Cheers,
> -- Kevin
> 
> Mark Cave-Ayland wrote:
>  > Obe, Regina wrote:
>  >
>  >> Then how come when I download the svn build from the site, I don't see
>  >> it in there?  Is there something wrong with the hudson build that its
>  >> not doing a re-run of configure maybe?
>  >
>  > I suspect you'll find that the Hudson build runs the pdf target directly
>  > rather than the all target - but you'll need to check the logs.
>  >
>  >> Okay will give this a try.  I assume this has to be the name of the
>  >> action as well or does it just have to be the actual action like.  so I
>  >> would change to
>  >>
>  >> all: html/postgis.html    ../postgis_comments.sql
>  >>
>  >> ../postgis_comments.sql: ./xsl/postgis_comments.sql.xsl
>  >> reference_new.xml
>  >>     $(XSLTPROC) ./xsl/postgis_comments.sql.xsl reference_new.xml >
>  >> $@
>  >
>  > Yup, that's it - you'll need to change both.
>  >
>  >
>  > ATB,
>  >
>  > Mark.
>  >
> _______________________________________________
> postgis-devel mailing list
> postgis-devel at postgis.refractions.net
> http://postgis.refractions.net/mailman/listinfo/postgis-devel
> 
> 
> ------------------------------------------------------------------------
> 
> * The substance of this message, including any attachments, may be 
> confidential, legally privileged and/or exempt from disclosure pursuant 
> to Massachusetts law. It is intended solely for the addressee. If you 
> received this in error, please contact the sender and delete the 
> material from any computer. *
> 
> ------------------------------------------------------------------------
> 
> * Help make the earth a greener place. If at all possible resist 
> printing this email and join us in saving paper. *
> 
> * *
> 
> * *
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> postgis-devel mailing list
> postgis-devel at postgis.refractions.net
> http://postgis.refractions.net/mailman/listinfo/postgis-devel
_______________________________________________
postgis-devel mailing list
postgis-devel at postgis.refractions.net
http://postgis.refractions.net/mailman/listinfo/postgis-devel



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/postgis-devel/attachments/20090223/40442aff/attachment.html>