[postgis-devel] loader/Makefile is broken in 1.4rc1

[Mark Cave-Ayland]

Devrim GÜNDÜZ wrote:

>> Mark will be able to explain the change to the Makefile in more
>> detail,  but in short, as of 1.4 PostGIS no longer uses the --prefix
>> option during configure 
> 
> Why?
> 
>> so there is no DESTDIR.  Rather, it installs in the 
>> same directory as the detected (or specified) PostgreSQL directory.
> 
> Why was it changed? Why do I have to install PostGIS under PostgreSQL
> directory? I believe RPM/deb/whatever users will want to stick with FHS.

The main reason there is no --prefix option anymore is because PostGIS 
1.4 delegates file locations/building to PGXS, and so is no longer 
responsible for knowing the final locations of files.

There are two reasons for going with PGXS: firstly, different
distributions have different directory structures for storing their
files; so tying everything into PostgreSQL means once PostgreSQL works,
everything else just works. Secondly, any changes in the PostgreSQL
Makefiles are automatically picked up via PGXS which saves us having to
maintain the whole set of randomly-hacked PostgreSQL Makefiles ourselves
(including supporting new platforms as and when they occur).

Now the issue here is that PGXS doesn't handle building front-end 
executables, and various experiments I tried to make this work failed 
miserably and so a non-PGXS version was devised. However, as you quite 
rightly point out, we need to know DESTDIR just in case we are building 
out of the tree...

So please can you try the attached patch? Basically we include the PGXS 
file in the loader Makefile but then override all of the interesting 
targets with the non-PGXS code. This then allows us to tweak the install 
and uninstall targets to make use of these variables from PostgreSQL. 
This allows a "make install DESTDIR=/tmp" to work correctly on my setup 
here.


ATB,

Mark.

-- 
Mark Cave-Ayland - Senior Technical Architect
PostgreSQL - PostGIS
Sirius Corporation plc - control through freedom
http://www.siriusit.co.uk
t: +44 870 608 0063
-------------- next part --------------
A non-text attachment was scrubbed...
Name: postgis-loader-makefile.patch
Type: text/x-diff
Size: 1493 bytes
Desc: not available
URL: <http://lists.osgeo.org/pipermail/postgis-devel/attachments/20090705/cc781c4a/attachment.patch>